Posted by dww on June 15, 2007 at 5:10am
5 followers
| Project: | Drupal.org Testing |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dww |
| Status: | closed (fixed) |
Issue Summary
it'd be helpful for testing to have a few projects that aren't configured to point to CVS at all, and that don't (and never will) have releases. e.g. everything grouped with "Drupal project" that's not core:
http://drupal.org/project/webmasters
http://drupal.org/project/infrastructure
http://drupal.org/project/documentation
...
Comments
#1
Still don't understand why drupal_execute() isn't hitting the full form in all its glory, and therefore, why the taxonomy terms have to be saved independently, but here's an initial patch.
#2
it is. that may have been one of the toughest problems to track down i've ever seen. i'll try to explain what's happening here...
function project_use_taxonomy() {return module_exists('taxonomy') && taxonomy_get_tree(_project_get_vid());
}
the code above is inherently flawed. _project_get_vid() automagically creates the vocabs if they don't exist, then when taxonomy_get_tree() is called immediately after, it caches the *empty* tree for the newly created vocab (static $children). any future calls to project_use_taxonomy() in the same page load will be FALSE -- like
if (project_use_taxonomy() && $node->project_type) {, which is in _project_save_taxonomy(), which is called from project_project_nodeapi().the fun all starts in devel_enable(), which calls _block_rehash(), which then eventually calls hook_block(), menu_block() fires up a _menu_build(), which gets you to project_menu($may_cache) -- and there's the first call to project_use_taxonomy() -- whew!
i'll leave it to you to file a bug against project module, since i'm not really sure how you want to handle it...
this code will need to be cleaned up once that bug is fixed.
#3
that sounds like fun bug! you can remove that block_rehash() call from devel if you wish. i don't think it does anythng anymore.
#4
Here's a reroll to eliminate offset.
I also added the documentation project to the array.
I tested this and it seems to work well. I also modified the comment about why drupal_execute() isn't fully effective here.
#5
Cool. Tested and committed to HEAD. Thanks.
--project followup subject--
Automatically closed -- issue fixed for two weeks with no activity.
--project followup subject--
Automatically closed -- issue fixed for two weeks with no activity.
--project followup subject--
Automatically closed -- issue fixed for two weeks with no activity.
#6
Automatically closed -- issue fixed for two weeks with no activity.
#7
doh! except they're still enabled for releases. ;) I noticed this while testing #325444-20: Make usage statistics EVEN MORE visible. Not sure when I'll have a chance to work on this, so for now I'm setting this back to unassigned.
#8
#9
Committed to HEAD and D5
#10
Automatically closed -- issue fixed for 2 weeks with no activity.