Tabs disappear on some views

No, no other menu entries. SELECT * FROM menu where path like 'popular%' order by path; shows just one entry for 'recent popular content'. The others aren't there, sorry - I don't know if that's how it's supposed to work or not.

select * from view_view where url like 'popular%'; returns 4 rows for alltime, recent, images and rides as I'd expect.

You are welcome to mess about in our development system if that would help. Contact me offline (homepage on Drupal profile has email address) to arrange.

A little more poking on this this eve. I placed some debug in the views_menu function. The menu looks to be being correctly built. A dump of the items returned by this shows:

    [14] => Array
        (
            [path] => popular/alltime
            [title] => All-time popular
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_alltime
                )

            [access] => 1
            [type] => 128
            [weight] => 0
        )

    [15] => Array
        (
            [path] => popular/latest
            [title] => Recent popular
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_recent
                )

            [access] => 1
            [type] => 640
            [weight] => 0
        )

    [16] => Array
        (
            [path] => popular
            [title] => Recent popular
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_recent
                )

            [access] => 1
            [type] => 22
        )

    [17] => Array
        (
            [path] => popular/images
            [title] => Images
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_images
                )

            [access] => 1
            [type] => 128
            [weight] => 1
        )

    [18] => Array
        (
            [path] => popular/rides
            [title] => Rides
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_rides
                )

            [access] => 1
            [type] => 128
            [weight] => 1
        )

    [19] => Array
        (
            [path] => popular/ride-meeting
            [title] => Meetings
            [callback] => views_view_page
            [callback arguments] => Array
                (
                    [0] => popular_ride_meeting
                )

            [access] => 1
            [type] => 128
            [weight] => 1
        )

Visiting the URL for the page with no menu items, and a URL with some menu items produced the same dump above.

I'm not really sure what's meant to happen here, but should we be pointing fingers at the core menu rendering code? Does the above look normal?

More tracing... think the problem is that when one includes "Node: Body" in the view, that node is loaded to gain the body and it is this that is replacing the menus with those that would be on the last loaded node's page.

More digging reveals it's not actually the load that's doing this as if one comments out the node_invoke_nodeapi($node, 'view', $teaser, TRUE); call (around line 462 in views_node.inc) then this problem disappears. Of course this probably breaks something else I don't know what this is meant to be doing!

More digging... this ultimately is down to the image_gallery.module. In image_gallery_nodeapi function (triggered from the call I previously commented out), there is a call to menu_set_location.

At first it would seem that we should remove the menu_set_location from image_gallery.module because when the node teaser is shown the location should not be modified. However, thinking on, views allows either teaser or body to be shown so changing the image_gallery.module will not work in all situations.

Seems that the views.module should also call menu_set_location at some point to make sure any changes that occurred during in node processing during the building of the view are removed. Perhaps inside the views_view_page function?

This has been accepted as a required change to image_gallery.module and bug/patch submitted there:

http://drupal.org/node/162496

Hence am closing this as one as a duplicate.