| Project: | Nodequeue |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dww |
| Status: | closed (fixed) |
Issue Summary
it looks like i'll need something like this for a site i'm building. any chance you'd be willing to commit this upstream and make this functionality part of the real nodequeue? seems like it could be handy for all sorts of powerful stuff.
technically, the patch needs work. 2 areas jump immediately to mind:
1) none of my changes to nodequeue.install are happy for pgsql.
2) the timestamp value isn't displayed in the UI anywhere (unless you put it in a view), and there's no way to modify it. it should probably be more like the node created field on nodes, so it's displayed (e.g. when listing all the nodes in a queue) and so you can edit it, too.
however, before i spend more time on those things, i wanted you to take a look and see if you'd even consider committing this functionality, first... hence, this needs review. ;)
cheers,
-derek
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| nodequeue_timestamp.patch.txt | 5.84 KB | Ignored: Check issue status. | None | None |
Comments
#1
Yes, having a timestamp on items like this is good practice. It costs us little and could provide features. I'm ok with it.
#2
excellent. in that case, i'll clean up the patch a little and post a new version in a few days.
thanks!
-derek
#3
new patch that fixes the pgsql stuff for the .install file. unfortunately, there are a bunch of other pgsql-specific bugs in nodequeue which i don't have time or interest to fix right now. so i can't fully test it there, but it's all working fine on mysql at least, and there shouldn't be anything mysql-specific in this patch.
also, note that i'm renumbering the 5.x-specific DB updates to 5000 as per the documented conventions. hope you don't mind.
#4
Applied!
#5