Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
forms system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2012 at 12:47 UTC
Updated:
29 Jul 2014 at 20:35 UTC
Jump to comment: Most recent file
Comments
Comment #1
Niklas Fiekas commentedFirst try.
Comment #3
yched commentedSo the patch removes the "customizable decimal separator" feature altogether - which is some ugly/fragile piece of code.
How would that be handled by the HTML5 number element ? Does this rely on browser locale settings ?
Comment #4
Niklas Fiekas commentedThe browser must submit the value to the server with a dot.
On the client side, browsers can do whatever they want. Like helping the user by replacing "," with "." or doing such a replacement in the background, allowing only either of the two, etc.
Comment #5
Niklas Fiekas commentedUpdating tests with the changed user interface texts.
Comment #6
sunThis looks good to go for me.
I merely wonder how html4 user agents will be handled - i.e., browsers which don't support any auto-conversion/localization for the decimal separator and so on. However, we can figure that out later on.
AFAICS, number fields always store their values with the regular/native decimal separator, so it also doesn't look like we need a update function here.
Comment #7
yched commentedWe'd probably need an update function to remove the 'decimal_separator' setting from the definitions of existing decimal and float fields. No need to keep useless entries rotting in there.
Comment #8
Niklas Fiekas commented@sun: Users would have to use a "." - otherwise the input will be rejected.
Comment #9
dries commentedLooks good and committed to 8.x. Thanks.