Hello,
I noticed that in reply_get_entity() the cache is stored as

$cache[$entity_type][$entity_type][$instance_id]

This ignores the entity_id. It should be

$cache[$entity_type][$entity_id][$instance_id]

changing this fixed a few issues for me when listing entities in a view.

CommentFileSizeAuthor
#1 1520412-reply.patch967 bytesloze

Comments

loze’s picture

Status: Active » Needs review
StatusFileSize
new967 bytes

Here is a patch that fixes this.

alan evans’s picture

Patch looks good to me.

james.williams’s picture

Assigned: Unassigned » james.williams

I'll take a look at this today.

james.williams’s picture

Assigned: james.williams » Unassigned
Status: Needs review » Closed (fixed)
james.williams’s picture

Status: Closed (fixed) » Fixed

Sorry, I should be setting these to fixed, not 'Closed (fixed)'.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

fixed typo