Closed (fixed)
Project:
IE Destroyer
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Jun 2007 at 16:24 UTC
Updated:
23 Oct 2007 at 03:43 UTC
Jump to comment: Most recent file
Comments
Comment #1
Christefano-oldaccount commentedSame here. Escalating issue, as this bug makes IE Destroyer unusable for me.
Comment #2
deskarrada commentedI just posted a issue about this same problem. Doesn't works at all. I've changed in every way possible.... and no response at all, always shows the same exact default text. But the extrange thing is that when u save changes they remain saved.............. but the banner still comming up with the default text....
I really need to have a differnt text in spanish, not just translate the default one but rewritting it with another stuff.
Please let me know if there is a way to make it work.
Comment #3
ramsamba commentedI have fixed this bug and also sent it to david. it works perfectly for me in my site. he'll look into it for implementing into v6.
in the meantime, for all of you who can't wait, you can download the modified iedestroyer.module file here:
http://www.esnips.com/web/ram-drupal
was unable to attach it to this post.
to use it, just download the file, and replace your modules/iedestroyer/iedestroyer.module with this file. you may want to rename your original iedestroyer.module in case you decide you want to revert back to the original iedestroyer.module.
everything should work fine just after replacing it.
md5 for the attachment: 6432aef06617d41c6e5e0ff44fca58cb
let me know if you have any problems, or if it went well for you.
Comment #4
Christefano-oldaccount commentedHere's a patch with ramsamba's code (to be applied against HEAD). I haven't tested it yet.
Thanks, ramsamba!
Comment #5
Christefano-oldaccount commentedPlease review.
Comment #6
deekayen commentedchristefano: you should review how to make a patch - the one line change shouldn't have diffed the whole file contents in the patch. http://drupal.org/patch/create
ramsamba: please review http://drupal.org/coding-standards for formatting your submissions
thank you both for working on this bug
One-liner patch committed to HEAD and DRUPAL-5. Will be making bugfix release shortly.
Comment #7
Christefano-oldaccount commentedOops, sorry about that. I did diff the two properly but it looks like the module hosted at esnips.com was downloaded as a binary instead of as text.
Comment #8
ramsamba commentedSorry, haven't learned how to submit a patch yet. Will do that now and act accordingly next time.
ram
Comment #9
(not verified) commented