Hello, I want to port counter module to Drupal 7. I have created a sandbox project here. The name counter was already taken in sandbox project, so I had to rename it to visits-counter:) I am porting this module. Please review the code and tell me if there are any problem.

Comments

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

I have copied counter.report.inc file from an earlier version of this module, but it still giving error:

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaldemos.Array' doesn't exist: SELECT COUNT(*) AS expression FROM (SELECT 1 AS expression FROM {Array} q) subquery; Array ( ) in PagerDefault->execute() (line 74 of /var/www/drupaldemos/includes/pager.inc).

I had also changed counter.report.inc file as per Drupal 7. Please review my updated code. The module is running fine in Drupal 7, except that Counter Report is not working due to that counter.report.inc file.

I am trying to find the bug there. Any updates from me will be notified to you :)

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Active » Needs review
drupalnesia’s picture

drupalnesia commented
Status: Needs review » Fixed

I just upload Counter 7.x-1.0-alpha1, please help to test and report any bugs.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Counter 7.x-1.0-alpha1 version is working fine.

But there are some missing functionalities found:

  • The reports functionality is missing in this version.
  • If I go to this link localhost/you_site_name/admin/config/counter i.e. if I click on the 'counter' link on the admin menu then its showing blank page.
  • There is a warning of drupal coding standards if you review its code using coder module.

I will be keeping you up-to-date with new bugs.

drupalnesia’s picture

drupalnesia commented
Status: Fixed » Needs review

I have a problem with TortoiseGit and also Git for Windows, they can not checkout from certain branch, but using Linux fine. I may use Linux Git if this issue can not fix this weekly.

Above bug causing some files not update into Drupal repo, such as Reporting which must be deleted, because I plan to use Drupal Content-type so we can use Views to generate custom reports.

drupalnesia’s picture

drupalnesia commented
Status: Needs review » Closed (fixed)

TortoiseGit (especially Git for Windows component) won't checkout for certain branch, but I have found a workaround. We must checkout entire branch!

I will works on D7 now, thanks.

NB: please open separated issue for problem/error because D7 port already done.