I created a patch for nodejs that backports nodejs_get_content_channel_users for the purpose of backporting 7-x chatroom module to 6-x.
The changes are: backpotrting and a few minor fixes: mistaken variable_get & mistaken drupal_add_js.
The server.js is basically copied from the nodejs 7-x.
Added package.json for easier nodejs modules install.

If the active maintainer could please review the code and maybe apply it.

ps.
This is my first time contributing anything for drupal, so please be patient with me. If you would like to contact me for clarifications, information, etc. please contact me on miroslav at propeople dot dk, or leave a message here.

CommentFileSizeAuthor
#6 nodejs.tar_.gz112.29 KBmiroslavbanov
nodejs-6-dev-fixes-and-backport.patch19.47 KBmiroslavbanov

Comments

Anonymous’s picture

Anonymous (not verified) commented

thanks for the patch.

will give it a proper review and test tomorrow.

miroslavbanov’s picture

miroslavbanov commented

@beejeebus
I have done more fixes since then. Please tell me if I should give you a patch with just those new fixes, or a patch that has all my combined changes, or you would rather have the the sources. I could also commit directly, if I only knew how. I'm still not exactly sure how to properly contribute.

julien’s picture

julien commented

Your patch seems legit. If you're keen to repost it, i'm keen to commit it on the 6x branch.

miroslavbanov’s picture

miroslavbanov commented

I just tried to create a new patch with all my changes, but the files I get when I do a git clone are different from what I see on the project page and repository viewer. I am not sure what to use for my diffs. If there are changes being made at the moment, then should I wait for them and then merge what I have as changes? I can also ignore that and just create diffs from the files that I had - 2012-01-05 datestamp = "1325724447".

julien’s picture

julien commented

Ok, what you can do is make a git clone.
Make your changes, and verify that everything work as expected.
Create a tarball from the all module and send it to me, i'll verify it again and commit it.

miroslavbanov’s picture

miroslavbanov commented
StatusFileSize
new nodejs.tar_.gz112.29 KB

OK, I have it here. I am attaching the complete modified module. Changes are only to the main module. I ran into difficulties making the server.js work on my node.js setup - dependency hell maybe, so I couldn't test this entirely, though I did merge my changes to server.js. I also added the server.usethis.js file. If you use the package.json to install your nodejs setup, and then use the server.usethis.js for the nodejs server, it should work. I don't see why we couldn't use the same 'node' part for both the drupal6 and drupal7 versions of this module, but you be the judge of that.

Please tell, if you need more information, or anything.

julien’s picture

julien commented

Ok let me give it a go with this, i'll get back to you soon.

bgogoi’s picture

bgogoi commented

helo, whts the status now?

bgogoi’s picture

bgogoi commented
Issue summary: View changes

added contact info