This patch adds support for creating thumbnails.
It stores the thumbpath in the cck table.
Partially based on the patch posted previously here (although little of that code remains)
Tell me what you think.

CommentFileSizeAuthor
#3 thumbnail_support_1.patch9.46 KBbojanz
#2 thumbnail_support_0.patch11.46 KBbojanz
thumbnail_support.patch11.48 KBbojanz

Comments

bojanz’s picture

bojanz commented
Status: Active » Needs review

Forgot to change status :/

bojanz’s picture

bojanz commented
StatusFileSize
new thumbnail_support_0.patch11.46 KB

Refreshing patch to fix small bug

bojanz’s picture

bojanz commented
StatusFileSize
new thumbnail_support_1.patch9.46 KB

Okay, the last one wasn't right, acted too fast, here's the new one.
Fixed bug and rerolled against latest head.

mykle’s picture

mykle commented

Hi. I'm using your imagefield.zip archive, i think it includes this patch. (although since that change got broken into multiple patches i really don't know how i'm supposed to find the most recent version.)

anyway, i had already created some types with the stock 5.2 CCK imagefield module,
and they didn't have the _thumbnail columns defined in the DB, which caused some
errors & failures. a quick ALTER TABLE solved the problem.

not sure if that's something you'd want to fix, or not. you could have some code in the imagefield.install file ...
deal with it like a drupal upgrade. or not. but i thought you'd want to know.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

Why do you re-implement functionality that is already provided by Imagecache module?
Imagefield shouldn't try to do that at all. It should rather try to automatically setup a new Imagecache preset for Imagefield thumbnails.

robloach’s picture

robloach
he/him
commented

Using ImageCache is the way to go. Checking if ImageCache is enabled and then using it is the best solution there is. ImageField could add a "thumbnail" preset at .install, and then use that when displaying the ImageField field item when editing the node. It would, of course, do all this only if ImageCache was enabled.

jpetso’s picture

jpetso commented

Either this issue or #127729: Create thumbnails is a duplicate. Could a maintainer please decide on one of those and close the other?

CoolDreamZ’s picture

CoolDreamZ commented

Agree that ImageCache should be used where available. Subscribing as this is an important issue - displaying the full size images in the edit node page is a serious performance hit.

dopry’s picture

dopry commented
Status: Needs work » Closed (duplicate)

ImageCache can't be used safely on content before a node has been saved in D5. ImageCache cannot be used for implementing thumbnails in D5.

I will most likely be using http://drupal.org/node/238636...