A WYSIWYG plugin that enables 3 additional buttons on the TinyMCE editor.
These buttons allow you to insert a breaking element that will clear floated elements above it. This is very handy when inserting pictures that you wish to be floated left, but then require your next paragraph to start 'below' the floated elements. Clearing the float enables you to do this.

It's the same project of Wysiwyg clear floats by meecect but for Drupal 7.x

And with 2 or 3 bug fixes.

My sandbox project : Wysiwyg TinyMCE Clear Buttons
Drupal core version : 7.x

Comments

morgothz’s picture

morgothz commented
Status: Needs review » Needs work

Manual Review:

  • You have all files on master branch. Only README.txt file must be on maste branch. You must create another 7.x-1.x development branch. See guidelines: http://drupal.org/node/1127732
  • Functions comments are not with the correct format. See documentation guidelines: http://drupal.org/node/1354
  • File wysiwyg_tinymce_clear_buttons.module, line 32: I think that absolute URL is not correct. You must relative paths.
yvh’s picture

yvh commented

Hello,

I have made all corrections.

For the absolute URL, I based on the imce_wysiwyg module code.

Thanks.

yvh’s picture

yvh commented
Status: Needs work » Needs review

Project pushed to 7.x-1.x

soncco’s picture

soncco commented

Hello @yvh, nice module :)

Ventral is not working now, but I found simple coding issues to fix:

  • Add a line in the end of .info file.
  • Remove whitespaces in .module file, lines 16, 35, 39, 41.
  • Remove /** @file .... */ from README.txt this declaration.
  • Implements instead Implementation of hook_help() in .module file line 9.
yvh’s picture

yvh commented

Hi @soncco,

Thanks a lot but the initial project was written by meecect ;-)

I have pushed the modifications.

++

soncco’s picture

soncco commented

Ventral is active again.
I found coding issues, Please check http://ventral.org/pareview/httpgitdrupalorgsandboxyvh1524204git-7x-1x

yvh’s picture

yvh commented

Done ;-)

But why this errors ?

24 | ERROR | Missing parameter type at position 1
26 | ERROR | Missing parameter type at position 2
29 | ERROR | Data type of return value is missing

Not type in Doxygen and comment formatting conventions...

yvh’s picture

yvh commented

Code ok.

Project pushed !

novalnet’s picture

novalnet commented
Status: Needs review » Needs work

Hi,

Manual Review :

1.project page is too short, see http://drupal.org/node/997024.
2.Please use l() to create link markup, dont create it by your own in wysiwyg_tinymce_clear_buttons.module line 51.
3. Data type of return value is missing in wysiwyg_tinymce_clear_buttons.module line 29.
4. It seems your code contains some validation error.So Please PAREVIEW your code.

Thanks,

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.