Problem/Motivation

Upon saving the user edit page, users are confused that their changes may not be submitted. This is because they see the password confirmation field again, and some fields may be pre-filled by the browser.

Original report by salvis

Ever since I've started running a Drupal site I've received complaints from newbie users struggling with changing their password. Finally, I've been able to identify one of the issues:

Newbie users can easily get confused when they click [Save] and the User|Edit form comes back to them, seemingly begging to enter and confirm the new password again, especially with a theme where the confirmation message is (too) discreet. If the browser is set to fill in the password, then it's even more confusing, because the Password field will be filled in and the Confirm password field will be empty, as if the confirmation somehow failed.

As an easy fix, I propose to redirect to User|View after saving, like we do for nodes, for example. For the normal user there's no point in staying on the User|Edit page.

For an administrator it could occasionally be useful to remain on the User|Edit page while trying out various settings. If we consider this an important feature, then we could make the redirection depend on not having the 'administer users' permission.

This does not require any string changes and if it's accepted, I'd like to see it back-ported to D7 and D6.

Steps to reproduce

Edit your user profile.

Proposed resolution

After a user edits their account redirect to the the view of the account. This will be consistent with what happens when editing other entities.

Remaining tasks

Write a patch.
Add a test.
Review.
Rejoice.

User interface changes

Yes, the user is redirected to the view of their account after editing the account.

API changes

Data model changes

Release notes snippet

Problem/Motivation

Comments

salvis’s picture

Status: Active » Needs review
StatusFileSize
new2.92 KB

Here's a patch.

Status: Needs review » Needs work

The last submitted patch, user_edit_redirect.1524438.1.patch, failed testing.

salvis’s picture

Status: Needs work » Needs review
StatusFileSize
new3.7 KB

Missed one test, try again.

iaha’s picture

I agree that this is a usability issue, but I think it's just as confusing to redirect back to the view. Also, if confirmation messages are not prominent enough to be noticed in a theme, that seems like a more widespread issue with the theme to me.

In my mind, a password reset is a common enough "lay user" process that deserves its own form and I think burying it in the middle of the catch-all user settings form is where the confusion lies.

Status: Needs review » Needs work

The last submitted patch, 3: user_edit_redirect.1524438.3.patch, failed testing.

Leeteq’s picture

Issue summary: View changes

Agreeing with @iaha in #4, and there are also other practical (positive) side effects of placing the password change fields on its own tab/url.

mgifford’s picture

Assigned: salvis » Unassigned

Unassigning so someone else can take it on.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dpi’s picture

Version: 8.2.x-dev » 8.3.x-dev
Issue summary: View changes
Issue tags: +Usability, +current password

Converted to issue template, added summary.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

avpaderno’s picture

Issue tags: -current password

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Issue summary: View changes
Status: Needs work » Active
Issue tags: +Bug Smash Initiative

I talked to aaronmchale about this in #usabiltity. They suggested checking what happens when editing other entities. I checked node, term and menu link. After saving changes to those content type one is redirected to the view of that entity. So, it seems that the user entity is the odd one out and that the suggested change here should be done to be consistent.

Although there is a patch here, it is outdated so I am setting this to Active.

aaronmchale’s picture

We reviewed this issue at #3277946: Drupal Usability Meeting 2022-05-06.

I thought it would be valuable to get the input of the wider group at the meeting, so presented this issue and the proposed resolution of redirecting to the View page instead of staying on the Edit page.

The group was also unanimously in favour of doing this, both in terms of making user consistent with the other core content entity types, but also in terms of avoiding the confusion of users described in the issue summary.

We also discussed if there would be any impact on admin users making updates to multiple users, and after discussion we determined that this would not be an issue because it's likely that admin users would access the User Edit screen from the People screen and so in that case they would already be redirected back to the People screen thinks to the existing "destination" parameter in the URL.

We should take care to ensure that any change here does not break that existing behaviour.

benjifisher’s picture

For the record, the attendees at the 2022-05-06 usability meeting were @AaronMcHale, @bnjmnm, @ckrina, @rkoller, @worldlinemine, @shaal, and me.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.