Any chance of support for comment uploaded files?

I am using the private download setting and therefore not being able solving it through .htaccess, I am happily using this module to force downloading on my filefields, but uploads in comment s (comment_upload module) don't seem supported.

Thanks
Max

Comments

arski’s picture

arski commented
Version: 6.x-2.4 » 6.x-2.x-dev

Sure, but I can't promise anything in terms of a time estimate..

If you can, a patch is always welcome, I'm assuming this would work similarly to the core upload module override.

Cheers

arski’s picture

arski commented
Title: Any chance of support for comment uploaded files? » Support for comment_upload files
Component: Miscellaneous » Code
Status: Active » Closed (works as designed)

Hmm, just checked and this already works - the comment_upload module uses the upload module's API basically do to all of its stuff, to the setting that you have under admin/settings/file-force will enable force downloading for comment_upload files too.

tezalsec’s picture

tezalsec commented

Thanks for your checking.

Great that it is already supported, but not in my case unfortunately.
I have the setting at admin/settings/file-force enabled.

I am using the comment in relation to a cck content-type called file-upload, using filefield as an upload facility. After creating a node with a file, it is possible to add a comment with an attachment. The filefield, only after setting "File Force: Generic Files" at the display settings of the content type, does add the "?download=1" string, but the comment uploaded file (with no display setting available?), does not... Where can this be configured then?

arski’s picture

arski commented

Hmm, well the setting in admin/settings/file-force is the one that should apply to all files added via the core Upload module. For example, you could enable file upload for any content type without CCK using that. And from what I got, you're using content_upload for the comments, which is also based on the Upload core module.

If it still doesn't work for you, please let me know what versions of Drupal and content_upload you are using. (CCK version should be irrelevant here as comments are not CCK-based).

Also, if you have a site with an example, that could help too.

Cheers

tezalsec’s picture

tezalsec commented

Thanks, but I can't replace the filefield with the core upload because of the extended features of filefield and other modules relying on it.

Current drupal version: 6.24
Current comment_upload version: 6.x-1.0-alpha6

Cheers

arski’s picture

arski commented

I wasn't suggesting you replace filefield with core upload. Just saying that it exists, and that comment_upload uses the core upload mechanism too. (hence the "for example")

tezalsec’s picture

tezalsec commented

I see ;-)

It was in response to "If it still doesn't work for you".

Because to be honest, I don't really know what steps to take from here..

arski’s picture

arski commented
Category: feature » support
Status: Closed (works as designed) » Active

Just updated to 6.24 and already had that version of comment_upload. Still works nice for me.

Any chance you could send a link to the site, or maybe upload a screenshot of the page where it's not working. Might spot something that I'm missing.

tezalsec’s picture

tezalsec commented

Thanks for your suggestion.

The website is a sort of private intranet solution, and I believe a screenshot wouldn't really provide any new insight. It would just show a node, a comment below it with a link to an attached file, and when hovering over the link, not adding the "?download=1" string...

Sorry I can't be of more help

arski’s picture

arski commented

Well, it works for me on the seemingly same setup.. Are you sure that you're using the private download method? And have you tried clearing the cache?

tezalsec’s picture

tezalsec commented

yep, have done both..

arski’s picture

arski commented

I don't have too many ideas left.. Maybe just 2 more:
1. Try switching the theme to Garland and clearing all the cache, see if that helps
2. Enable the standard Upload functionality for some content type and create a node with an uploaded file - see if that displays with download=1

Could you maybe post the link to the file in the comment (you can remove the domain details..)

It is highly likely that you have some other module and/or theme that implements the theme function used for displaying Upload files.. so basically you would need to try and locate that.. I don't imagine what else could be going wrong.

tezalsec’s picture

tezalsec commented

Hi,

i've done what your suggested. the theme change didn't make a difference,

but I did find out that the issue doesn't just occur with the filefield, but also with the standard upload functionality. I tested it by enabling both the node upload ability and the comment upload ability on the page content type. Then created a testing page (ref to self: https://www.example.org/content/testing), resulting in a correctly functioning attachment on the node (with the "?download=1" string), but the attachment on the comment did not have the added string... so whatever is causing it, it seems to have nothing to do with making it available to the cck filefield.

arski’s picture

arski commented
Category: support » feature
Status: Active » Fixed

My my, I see now.. I had iTweak Upload enabled which interfered a lot there.. *duh* :)

OK, committed a fix that makes comment_upload files controllable just like the standard Upload files - you'll need to enable a setting in admin/settings/file-force to make it work. The commit should appear within 12 hours on the -dev branch.. I'll also roll out a new release sometime next week I guess.

This should be it, sorry for the confusion.

Cheers

tezalsec’s picture

tezalsec commented

Great, problem solved!

I'll await your new release.

Thanks for your work.

Cheers

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.