Warning: Parameter 1 to panelizer_entity_load() expected to be a reference, value given in /var/www/d7/includes/module.inc on line 819

hook_entity_load() doesn't pass by reference, and saying it does breaks the call to it.

CommentFileSizeAuthor
#2 webform_entity-1524730-2.patch711 bytestim.plunkett
panelizer-entity_load.patch519 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Wrong function signature for panelizer_entity_load() » hook_entity_load() needs to be called with module_implements/$function
Project: Panelizer (obsolete) » Webform Entity
Version: 7.x-2.x-dev » 7.x-1.x-dev
StatusFileSize
new webform_entity-1524730-2.patch711 bytes

It's not documented, but core goes out of its way to not use module_invoke_all so that $entities can be passed by reference.

See http://api.drupal.org/api/drupal/includes%21entity.inc/function/DrupalDe...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Opened #1524770: hook_entity_load() can pass $entities by reference as well.

tizzo’s picture

tizzo commented
Status: Needs review » Reviewed & tested by the community

Looks good, commit away!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to both branches.

http://drupalcode.org/project/webform_entity.git/commit/51d78d5
http://drupalcode.org/project/webform_entity.git/commit/6921950

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.