Simple Slide

welcome

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxalbertliu1516046git.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

If you got any questions on this please ask!

Manual Review:-

• simple_slide.module:- Line 3, Add a comment Implements hook_menu(). Refer Doxygen and comment formatting conventions
• simple_slide.module:- Make sure to add comment above all hooks and functions. Line 17, 25, 31, 40
• simple_slide.module:- Line 42, you are passing :type but it has not been defined in your query at line 41. Make it n.type in (:type
• simple_slide.module:- Line 46, Use a proper name for variable, instead of $n
• simple_slide.install:- Line 6, 84, use proper naming conventions for variable names.
• simple_slide.tpl.php:- Add a file directive at the top, variable that are available to this template file. Refer Doxygen and comment formatting conventions.
• simple_slide.tpl.php:- Line 86, 98, 99 do not create image markup yourself, use theme('image', ...) instead.

Please, don't assign application issues to yourself (only the current reviewer should do this).

Hi,

Please fix the previously reported issues and then only mark it as 'needs review'. There are coding issues with your module. Refer them here http://ventral.org/pareview/httpgitdrupalorgsandboxalbertliu1516046git

• End of line character is invalid; expected "\n" but found "\r" :- I have tried opening your module in different editors. But when i open files in vi editor, it appends ^M at the end of each line which is not showing up in any other editor.

  I would suggest you to create new files and paste the code from the old files. Please use a nice editor or just go with the basic linux gedit. Your code styling or appearance should be consistent across all editors.

  First, work on this, and i think it will also solve Readme file errors.

• Files must end in a single new line character :- If there is an empty line, this error shows up. Remove the extra lines at the end of the file.

The correct git clone?
git clone http://git.drupal.org/sandbox/Albert.Liu/1516046.git simple_slide

Hi Albert.Liu

I installed your module, and clicked add content, pressed Simple Slide, added a picture and pressed save.
Nothing really happened then, other than i could see my picture i just added, so i thougth hmm what now, so i turned to your README.txt which said

Drupal Simple Slide module:
------------------------
Simple Slide is a simple module to create a slide show in drupal 7.
It is very quickly and easily to config this module. In addition,
It provide very fancy animation to display what you want.

At this point i pretty much gave up, which is a shame.

Here is some thoughts..

Why can i only upload one image to Simple Slide content type, that makes for a borring slide ehh?
I think you should work on your README.txt, and be sure to add some installation instructions. :)
Well it dosn't seem to work @ my machine, i did cleared the cache multiple time, did you test your module on a clean drupal installation?

About simple_slide.tpl.php
This is abit messy don't you think? You should avoid as much logic in here, try only to set some markup here, and let the logic be in .module.
You want your css, js in their own files, and add them from your .module. Also you have head + body tags in you tpl, you only want the markup for your slider here like

    <div id="simple-slide-wrap">
      <img src="<?php print $path; ?>/img/new-ribbon.png" width="112" height="112" alt="New Ribbon" id="ribbon">
      <div id="simple-slide">
        <div class="slides_container">
          <?php foreach($slide_img as $k => $img): ?>
          <div class="slide">
            <?php print $img; ?>
            <div class="caption" style="bottom:0">
              <p><?php print $content[$k]; ?></p>
            </div>
          </div>
          <?php endforeach; ?>
        </div>
        <a href="#" class="prev"><img src="<?php print $path; ?>/img/arrow-prev.png" width="24" height="43" alt="Arrow Prev"></a>
        <a href="#" class="next"><img src="<?php print $path; ?>/img/arrow-next.png" width="24" height="43" alt="Arrow Next"></a>
      </div>
    </div>

I also fell over

  <link rel="stylesheet" href="<?php print $path; ?>/css/global.css">
  <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.5.1/jquery.min.js"></script>
  <script src="<?php print $path; ?>/js/slides.min.jquery.js"></script>
  <script src="<?php print $path; ?>/js/jquery.easing.1.3.js"></script>

But where are these files?

Finally your demo site seems to disfunction :).

I am changing this to needs work, i will add some links for you later when i got time.

Best regards
Elvar

Hi Albert.Liu,

When I create one Simple Slide content and when I hit Save button, user is directed to page on where uploaded image is displayed (with no slide effect)

After reading README.txt,
Goto
Home » Administration » Configuration » Media » Simple Slide Settings
when I hit Save configuration I got error, please find attached screen shot.

Try with fresh module install

I am agree with Elvar, uploading single image per content is boring.

Status updated

Status updated

Project applications are tasks.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

change demo site link