GROUP_CONCAT() is used in leech.module (line 2781).
Since this was added in MySQL 4.1, the leech.module does not work on an older MySQL.

(info about GROUP_CONCAT: http://dev.mysql.com/doc/refman/4.1/en/group-by-functions.html )

I make this a bug report, because this information should be added into the README or on the project-page.

CommentFileSizeAuthor
#1 patch_leech_for_mysql40_152509.patch2.36 KBJo Wouters

Comments

Jo Wouters’s picture

Jo Wouters commented
Component: Documentation » leech
Status: Active » Needs review
StatusFileSize
new patch_leech_for_mysql40_152509.patch2.36 KB

Instead of changing the documentation, it may be better to change the code :-)
You can find a patch attached.

(There still seems to be a problem with non free-tagging categories; but that is not related to this change; so I will report it in a seperate issue.)

alex_b’s picture

alex_b commented
Status: Needs review » Closed (fixed)

Thanks, Jo.

I tested and committed and as I was just about to roll out a new minor version, your patch is part of that (1.8).

The reason why we where using group_concat was to get some processing time from the php layer to the database and to reduce the hits to the database. However, I think 4.0 compatibility is more important, if the faster code is needed, a hack will be required.

Ideally, we would determine the mysql version on installation and adapt the queries to it. Until that happens, I ll send the group_concat guy to sleep in the repository.

Alex