I read the README.txt from start to finish, nothing on Captcha.

In line 67 of fb_registration.module, Captcha are disabled by $form['captcha'] = NULL;. Reading the code, it should be only after the form is submitted. For my case, it is a new registration form. Could this a bug?

CommentFileSizeAuthor
#5 fb_captcha-1525116-5.patch1.05 KBckng
#2 fb_captcha-1525116-2.patch561 bytesckng

Comments

Dave Cohen’s picture

Dave Cohen commented

Not every form element is supported by fb_registration.module. Most users enable that module without understanding what it does. Most users don't really want it enabled for their site.

If you can get captcha to work in the fb_registration form, by all means please submit a patch.

ckng’s picture

ckng
Primary language English
commented
StatusFileSize
new fb_captcha-1525116-2.patch561 bytes

I meant the captcha in Drupal form, that is disabled by the fb_registration.
Attached is the patch to have Drupal captcha remain, does not interfere with FB registration from my tests.

On a side note, you are right that can't get the fb_registration captcha (FB form) to work.

ckng’s picture

ckng
Primary language English
commented
Status: Active » Needs review
Dave Cohen’s picture

Dave Cohen commented
Status: Needs review » Needs work

There's already a couple places in that file where it tries to deal with captchas, and if I recall correctly it was working at least somewhat in D6. In D7 I haven't set it up.

So my question is, is that other code attempting to deal with captcha broken? I feel like hardcoding the 'captcha' key there is not the best. If it's broken, I'd rather see a fix in _fb_registration_form_alter_fields(), where there's already some code for captcha.

ckng’s picture

ckng
Primary language English
commented
Title: Captcha disabled by fb_registration » Enable Captcha on Drupal registration form (disabled by fb_registration)
Status: Needs work » Needs review
StatusFileSize
new fb_captcha-1525116-5.patch1.05 KB

Updated the patch as suggestion in #4 to do it in _fb_registration_form_alter_fields(), by introducing '#fb_registration_retain', if a field should be kept and not removed from Drupal form.

This allows facebook captcha and Drupal captcha to appear on both forms.

If you would like to provide an option for user to say 'Enable captcha on Drupal form', default to disable to maintain previous way of how the module works, I could redo the patch.

ckng’s picture

ckng
Primary language English
commented
Category: support » feature
fluffy’s picture

fluffy commented

The patch in #5 worked for me, I can now have both signups with Facebook and regular Drupal accounts and no bot signups.