View arguments are ignored on area [#1525420]

As the the view field is global, it may be added in all view area, like header, footer or empty text. In such cases, the arguments are not set correctly.

The patch below fixes that (in a proper but quick way, see below).

On the other hand, I think the view field handler should be different than the area handler. Like that the code could be simpler and edge cases handled more easily.
If you need some help on that, I would be glad to become a co-maintainer.

Comment	File	Size	Author
#5	views_field_view-view-arguments-ignored-in-area-1525420-5.patch	904 bytes	b-prod
#1	views_field_view-arguments-ignored-on-area-1525420-1.patch	1.73 KB	b-prod

Comments

Comment #1

b-prod commented 10 April 2012 at 11:42

Status:

Active

» Needs review

Status	File	Size
new	views_field_view-arguments-ignored-on-area-1525420-1.patch	1.73 KB

Patch attached

Comment #2

damiankloip commented 11 April 2012 at 10:21

Is this with query aggregation on or off? Will have a look at the patch shortly!

Comment #3

damiankloip commented 14 May 2012 at 16:56

Status:

Needs review

» Fixed

I have just committed a patch that should fix this. I don't think we need to create a mock view object. We can just populate the values object at the start of render if we need to.

Comment #4

28 May 2012 at 17:00

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #5

b-prod commented 27 October 2012 at 22:06

Priority:	Normal	» Critical
Status:	Closed (fixed)	» Needs work

Status	File	Size
new	views_field_view-view-arguments-ignored-in-area-1525420-5.patch	904 bytes

This is not fixed in the new version. I set this issue as critical because the bug becomes aged and is pretty simple to test and fix.

To reproduce such bug, just create a view (content) with 2 displays:

1 display (table) that has a field [tid] that relates to a relationship to the main node (you may add some other fields like nid to have some data to display)
1 display (HTML list) that has a [tid] context argument and display for example only the node titles

In the first display, create in the header or footer a views field that uses the second display and pass the [tid] as argument.

You expect to see a table, followed by an HTML list containing the node titles.

But you will only see the table, because there are no field handlers loaded to use with the tokens.

I saw fixed a part of the code in the previous patch, about empty values in areas. So the only issue to fix now is simply to ensure that the field handlers are loaded before trying to make the replacements.