It would be nice to have instructions for usage in the readme. It now only contains a short announcement.

CommentFileSizeAuthor
#3 redirect_readme-1525554-3.patch3.02 KBdani3lr0se

Comments

pere orga’s picture

pere orga
Primary language Catalan
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

I agree with this

pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Reviewed & tested by the community » Active

Sorry, wrong ticket!

dani3lr0se’s picture

dani3lr0se commented
Status: Active » Needs review
StatusFileSize
new redirect_readme-1525554-3.patch3.02 KB

I realize that this is old but it's still necessary. It's always nice to have a useful README and per Drupal standards it's recommended to have one with useful info, etc.

Here is a patch that adds a useful README. Hopefully this helps. :)

tomsegarra’s picture

tomsegarra commented

This looks good to me, at least for a start!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Nice documentation! Thanks for adding this readme. I tested all links and configurations, and every thing works as expected. Spelling, grammar and punctation look good.
Patch applied locally

I found an extra line, but I don't think that should hold up committing this patch. Marking RTBC

  1. +++ b/README.txt
@@ -1,3 +1,88 @@
+

    nitpick
    there should only be two empty lines preceding headings.

alex_optim’s picture

alex_optim
Location Tallinn
commented

Looks good.

pifagor’s picture

pifagor commented

  • pifagor committed 3f9de05 on 7.x-1.x authored by daniel_rose 
    Issue #1525554 by daniel_rose, Pere Orga, alex_optim, pifagor: Provide...

  • pifagor committed 64ae156 on 7.x-2.x 
    Issue #1525554 by daniel_rose, Pere Orga, alex_optim, pifagor: Provide...
pifagor’s picture

pifagor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.