Problem/Motivation

Vote up/down (at least when used with the voting field) throws a PHP notice, since vud_votes_proxy uses an undeclared variable.

Proposed resolution

Fix the typo in the code.

Remaining tasks

Review submitted patch, test submitted patch, apply submitted patch.

CommentFileSizeAuthor
#2 0001-Issue-1525778-by-Itangalo-marvil07-Fixed-vud_votes_p.patch1.85 KBmarvil07
#1 1525778-1-fix_typo_in_vud_votes_proxy.patch457 bytesitangalo

Comments

itangalo’s picture

itangalo commented
Status: Active » Needs review
StatusFileSize
new 1525778-1-fix_typo_in_vud_votes_proxy.patch457 bytes

Patch attached.

marvil07’s picture

marvil07 commented
Status: Needs review » Fixed
StatusFileSize
new 0001-Issue-1525778-by-Itangalo-marvil07-Fixed-vud_votes_p.patch1.85 KB

Right, some things were needed to make vud_votes theme work again. I attached the patch I added to 7.x-1.x.

BTW template suggestions are not working since the initial d7 port(drupal_discover_template() was removed from core on 7.x), so a typo there also prevented using the right template for this theme hook, I added some lines to make the base case work.

In the other side, we are not using vud_vote theme function anywhere with vud_field, I am curious how you notice it.

itangalo’s picture

itangalo commented

Thanks for quick response!

I'm displaying vote up/down in Views, and I guess that's how the widget got called.

nguyentran’s picture

nguyentran commented

Hello,

I have just installed the newest version of this module, the module has already patched, but the widget display not work properly. Please help.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.