Drupal 7 port of 6.x-1.0 version of uc_po

I messed up when I tar'd that up and forgot the directory (d'oh). This one should work better and create a uc_po sub dir instead of just plopping everything in the current dir...

Awesome, Demma10, thanks for checking out my code and thanks for the fixes!

I updated my code w/the fixes to the two token functions that you added (I think there were just the two functions uc_po_tokens and uc_po_token_info, correct?)

I will have a look @ the code and see if I can figure out that views error... this was my first attempt at using the hook_views_data hook so I probably have something wrong in there.

thx!

-kevin hanser
Energy Web Design
http://energywebdevelopment.com

Demma10,
I wasn't able to duplicate the join error that you are seeing on the "Search by PO" view. I thought at first it was because I had warnings turned off so I wasn't seeing it, but after confirming that all errors are being shown, I can't seem to get that error.

I did change a few things in how I named the relationship in hook_views_data so maybe that will help. (not sure that was the issue though since I wasn't able to make it happen for me...)

I've attached a new snapshot of my code which has been updated with your token hook changes and the updated view in it if you want to download it and give it a try. Be sure to disable and then enable the module after putting the new one in place to make sure the view is re-created with the new info.

thx!

-kevin
Energy Web Design
http://energywebdevelopment.com

Wow, that's really weird! Thanks for tracking that down for me; I'm not sure how those relationships got removed, but sure enough they weren't there. The strange thing is that if I edit the field thru the view gui, it then has the correct relationship listed and all I needed to do was save. I don't know when/why those two relationships disappeared... probably somewhere along the way when I renamed the relationship(s) and re-exported/imported the view. Thanks for tracking that down for me!

Yeah I totally forgot about the Devel and Coder modules; I should try to make sure to install those on whatever site I'm doing my devel on from now on.

As for the sandbox project; sure, I will go and get one set up. I didn't do this initially since this was an existing project and I wasn't sure what the procedure was for adding in a port to an existing project. From the project page on this it looks like the project is somewhat abandoned... it says the status is "seeking new maintainer" so I wasn't sure how I would go about getting this port added into the official project.

Once I get it set up in the sandbox I'll post here w/more details! Thanks for your help Demma10

Ok I have set up a sandbox project here: http://drupal.org/sandbox/bradjmsu/1539674

I added my latest snapshot into the git sandbox repository; this includes the fixes to the relationships on the views.

Also attached a snapshot .tar.gz.

Let me know how this one works for you,

thx!

-k

Hmm, that's something I never tried to do :) Let me look into it and see what I can find out.

-k

Hmm, interesting. Yeah I get an error from uc_order.module when I try to edet an order (with or w/out a purchase order):
Fatal error: Nesting level too deep - recursive dependency? in /home/roco/dev/sites/all/modules/ubercart/uc_order/uc_order.admin.inc on line 1065
It appears to be something I've introduced w/my module, since a version of the same site w/out the uc_po module does not have this problem.

Looking into it now...

Ok now I'm more confused; maybe this isn't something I caused? I disabled the uc_po module on my dev site, and tried to edit a credit card order (actually no edit was performed, I just loaded it in the edit screen and pressed the save changes button).

And I'm getting the same error.. I added some degugging output into the uc_order.admin.inc file and it seems like it's bombing out when it tried to process the 'products' portion of the order.

This is the code that's bombing, on the "if" statement line... (I added in the echoes for debugging):

<?php  
function uc_order_edit_form_submit($form, &$form_state) {
  $order = uc_order_load($form_state['values']['order_id']);
  $log = array();

  foreach ($form_state['order'] as $key => $value) {
echo ("<pre>key: " . $key . ", v: " . $value . "</pre>");
echo ("<pre>order key value: ". $order->$key . "</pre>");
echo ("<pre>order: " . print_r($order,1)."</pre>");
    if (!isset($order->$key) || $order->$key != $value) {
      if (!is_array($value)) {
        $log[$key] = array('old' => $order->$key, 'new' => $value);
      }
      $order->$key = $value;
    }
  }
?>

And this is what my debugging echoes produce:

key: products, v: Array
order key value: Array
order: stdClass Object
(
    [order_id] => 18
    [uid] => 2
    [order_status] => completed
    [order_total] => 0.01
    [product_count] => 1
    [primary_email] => kevin@energywebdevelopment.com
    [delivery_first_name] => 
    [delivery_last_name] => 
    [delivery_phone] => 
    [delivery_company] => 
    [delivery_street1] => 
    [delivery_street2] => 
    [delivery_city] => 
    [delivery_zone] => 0
    [delivery_postal_code] => 
    [delivery_country] => 840
    [billing_first_name] => kevin
    [billing_last_name] => hanser
    [billing_phone] => 
    [billing_company] => 
    [billing_street1] => my address
    [billing_street2] => 
    [billing_city] => sebewaing
    [billing_zone] => 33
    [billing_postal_code] => 48759
    [billing_country] => 840
    [payment_method] => credit
    [data] => Array
        (
            [cc_data] => 5K;1+,%nJMV^mzIi%M]!5(e.O$La0X-=O&?<}"3Wb{J`MX}uxO$C4ez!X_S!z^G51_SH%SZ_J"!#s3V4crq5S?gimRxvLnXeAJLqMx?lWHlr)yCchMoHqa}ofAj]CNUrWgIS(Uy9(=!M6IaPo9MxjBym2t{ :Qt,IgXpt{pw
            [complete_sale] => existing_user
        )

    [created] => 1332192037
    [modified] => 1332192142
    [host] => 71.13.94.28
    [currency] => USD
    [products] => Array
        (
            [14] => stdClass Object
                (
                    [order_product_id] => 14
                    [order_id] => 18
                    [nid] => 1
                    [title] => Your Product Here!
                    [model] => your-product-1
                    [qty] => 1
                    [cost] => 0.00000
                    [price] => 0.01000
                    [weight] => 7
                    [weight_units] => oz
                    [data] => Array
                        (
                            [attributes] => Array
                                (
                                    [Color] => Array
                                        (
                                            [3] => Green
                                        )

                                    [Size] => Array
                                        (
                                            [5] => Medium
                                        )

                                )

                            [shippable] => 0
                            [type] => product
                            [module] => uc_product
                        )

                    [rdf_mapping] => Array
                        (
                        )

                    [order] => stdClass Object
 *RECURSION*
                    [order_uid] => 2
                )

        )

    [payment_details] => Array
        (
            [cc_owner] => Kevin Hanser
            [cc_number] => 5554
            [cc_exp_month] => 5
            [cc_exp_year] => 2013
        )

    [quote] => Array
        (
            [accessorials] => 
        )

    [line_items] => Array
        (
            [0] => Array
                (
                    [line_item_id] => subtotal
                    [type] => subtotal
                    [title] => Subtotal
                    [amount] => 0.01
                    [weight] => 0
                    [data] => Array
                        (
                        )

                )

        )

    [rdf_mapping] => Array
        (
        )

)

Fatal error: Nesting level too deep - recursive dependency? in /home/roco/dev/sites/all/modules/ubercart/uc_order/uc_order.admin.inc on line 1068

It's crapping out when it gets to the 'products' section of the order. Which appears to have some recursion in there... but I'm not sure that's a bad thing. I've seem arrays w/recursion in them all over in Drupal so I'm not sure if this is out of the ordinary or not.

I'm really still not sure at this point, I need to do some more investigation on this and other sites I have running ubercart.

Is this the same error you're seeing, Demma10?

thx

-k

Updated: I updated my ubercart to the latest dev version (7.x-3.x-dev 2012-Apr-20) and now I'm not getting that error anymore. (it was still present when I tried version 7.x-3.0)

So that error doesn't appear to be something that uc_po caused; however, when I try to edit a PO number now it saves w/out error, but it doesn't actually update the PO number either... so I'll work on seeing how I can fix that.

-k

I have made some changes to the uc_po.module code; Looks like I didn't have code in there for the op 'order-save' that occurs when you edit an order. Possibly this is some hook that changed or didn't exist in D6/UC2 since there wasn't anything there to do this previously... not sure if there was code written in for editing PO numbers or not, since I didn't see any existing code to update the uc_payment_po table which is where the PO's are actually stored.

I also am not sure if the token hooks are actually necessary for this module or not... there was an error being caused by one of them, and the po number still seemed to show up fine despite the error. I added some code into the hook to avoid the error, but I'm not really sure if these are necessary or not. I've left them in since I don't want to break anything right now...

I updated the sandbox project / git repository w/my latest changes, and I've also attached the latest SVN snapshot .tar.gz

I did some testing on my site, and I was able to place a PO order as a user and it was recorded ok.
I also tested editing the PO number as an admin and that appears to be working now. When you edit / add a po number it records the change in the admin comments section now too for historical purposes.

Give it a go and see what else you can find! Thanx again for your testing assistance, I seem to miss some of the bugs sometimes when I'm doing my own testing, so w/out your help I may not have found these errors until the customer found it on their site :)

-k
Energy Web Design
http://energywebdevelopment.com

I applied your patches, but the 2nd one (for the token hook) was causing an error; something about "cannot use string offset as array" on line 80 which would be the line that was changed to:

<?php
$replacements[$original] = $order->payment_method['data']['po_number'];
?>

The first one seems to work well, I put that in the sandbox. I also added the sanity check on delete that you suggested. I have some other projects I need to focus on today unfortunately or I'd try to figure out what that error is in the 2nd patch.

Thanx!

-k

@jenstechs:

Hmm I guess I didn't realize there wasn't a "latest version" snapshot .tar.gz in the thread. Been a little while since I worked on this project, and I just reviewed the thread now after seeing your comment.

I believe the code that's in the git sandbox repository is a working copy. I will try to get a snapshot .tar.gz rolled up in the next couple days and post it to this thread. If you don't want to wait, you can grab a copy from the git sandbox yourself from here: http://drupal.org/sandbox/bradjmsu/1539674

I'll have to check and make sure the latest patches have been applied to the sandbox code, but I'm pretty sure that the code in the git sandbox is working/functional (I was and still am using this code on a customer site so as far as I know it's still working). I probably won't have a chance to look it over and get a new .tar.gz out until this weekend though, so if you need it really quick the git sandbox repo may be your best bet.

Let me know if you encounter any issues!

thx

-k

I have attached a SVN snapshot of the code that I was last using on the site that I created this for. I compared it to the code that the site is still running and it seems to match.

I haven't had a chance yet to see if the git repo contains the same code, my git client was acting up on me and I don't feel like messing with it tonite :) I also need to verify if my code contains all of Demma10's patches. I think it does, but there may be one at the end that didn't get implemented(?).

As far as I know, this is a working version of the module. please let me know if you encounter any issues.

thx

-k