hello

the request was to
1. show a xls table attached to the node as a file like an inline image
2. in the case that there are more than one attachment with the same name (newer versions) then show the last one

Therefor some modification to the source code were done:
* for point 2 (see above) the function _inline_fileobj was modified so that the last entry is selected
* for point 1 the function _inline_decide_img_tag was superseded by the new function _inline_decide_inline_tag which returns some find of file type.
for each file type there must exist a function creation the according output. In this case the new function is theme_inline_xls

This is my absolute first try to struggle the the drupal code, so the attached code is absolutely alpha!
There are hard coded pathes, mime type, character transformation ...

The code must be worded on!
I would be lucky if somebody more experienced than me in handling drupal code will have a look at the code.

Regards
schildi

CommentFileSizeAuthor
#4 inline.module-excel_0.patch6.25 KBschildi
#2 inline.module-excel.patch2.56 KBschildi
inline.module.tgz4.81 KBschildi

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Thanks for contributing!

Could you please attach a patch instead? See http://drupal.org/diffandpatch for further information on how to create patches. Never attach compressed archives, please.

schildi’s picture

schildi commented
StatusFileSize
new inline.module-excel.patch2.56 KB

OK, here is my simple patch.

When testing the code please (install the tools if necessary and) adjust the pathes in theme_inline_xls and have a look at the coded mime types in function _inline_decide_inline_tag.

The code currently does not contain a check for the correct pathes since for some (unknown) reason the functions is_executabel always returns FALSE.

This is my first try to contribute code to the drupal project, so please feel free to tell me your thoughts.

Regards
Schildi

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: MS excel (xls) table viewable a 'inline' code » Allow Excel (xls) tables to be viewable inline
Category: task » feature

You should read and adhere to the Drupal Coding Standards and might additionally install Coder module if you want to contribute usable code for Drupal and contributed modules.

Some hints:

  • 3rd party application detection and configuration is executed too late in theme_inline_xls(). If a XLS file can't be rendered this way, it should be displayed like a regular inlined file.
  • Upload module does not support files with the same filename. So the array_reverse() in _inline_fileobj() is not needed.
  • Whilst renaming _inline_decide_img_tag() to _inline_decide_inline_tag() is ok, you should implement the new code into the old function. You have removed a critical function currently.
  • The mentioned function is_executabel() [typo] does not exist in your patch.
schildi’s picture

schildi commented
StatusFileSize
new inline.module-excel_0.patch6.25 KB

Attached you find a new patch for displaying excel (xls) tables.
ad 1) settings are now done at the right place
ad 2) upload module DOES support files with the same filename.
When you upload a (modified) file a second time this will result in e.g.

      mysql> select fid, nid, filename, filepath from files where filename like '%Excel%';
      +------+------+----------------+------------------------+
      | fid  | nid  | filename       | filepath               |
      +------+------+----------------+------------------------+
      | 6701 | 2248 | Test-Excel.xls | files/Test-Excel.xls   |
      | 6702 | 2248 | Test-Excel.xls | files/Test-Excel_0.xls |
      +------+------+----------------+------------------------+

So the array_reverse() in _inline_fileobj() is needed.
ad 3)
I don't really know what you mean. I tried to change the existing function as less as possible
and implement the new functionalities in a new function.
ad 4)
Solved, I had to adjust the settings for the virtual host.

Regards
Schildi

Please again feel free to comment the code

schildi’s picture

schildi commented

To see the results of applying "inline" to excel files see e.g.
http://archiv.bgv-rhein-berg.de/node/2382

Regards
Schildi

dirkson’s picture

dirkson commented

Doesn't patch cleanly against v6 of inline

schildi’s picture

schildi commented

The module (D6 version) is evolving quickly. Possibly the patch will bot be necessary in future.
So I am not planning to port the patch to D6.
Did you have success in applying the patch ?