Posted by rosgar on June 18, 2007 at 1:21pm
Jump to:
| Project: | ImageCache |
| Version: | 5.x-1.0 |
| Component: | Documentation |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Strange, when I'm using a Safari browser, I can see a small question box at the start of a teaser story or even in a main body. But in Firefox, you can't see it but you can tell there's a invisible image because the way the text indented to the right.
I'd just used this in my style.css
#content img {
border: 0;
float: left;
margin-right: 5px;
margin-top: 5px;
| Attachment | Size |
|---|---|
| duh.jpg | 51.58 KB |
Comments
#1
My sympathies:
http://drupal.org/node/148497
#2
Hmmm... so the drupal developers don't care with this kind of issue? Problem with the template I guess.
#3
It's a hack for imagecache but it works:
http://drupal.org/node/88136#comment-230649
My version of imagecache is 5.x-1.3 and the line to change is 744.
#4
So, are you saying editing the imagecache.module..
at line 744
if ($path) {
'; }
return '
ok!
#5
oooppps!
should be...
if ($path) {return '<img src="'. $imagecache_path .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. $attributes .' />';
}
#6
it didn't work. It interferes with line 753...
So, I change this again...
if ($path) {return '<img src="'. $imagecache_path .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. $attributes .' />';
}
to this
if ($path)return '<img src="'. $imagecache_path .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. $attributes .' />';
}
deleting the {
#7
this little hack works! would be great if this fix could go into the actual module.
#8
A fix in the module would be good but should the code actually be testing for $imagecache_path not $path - ie
if ($imagecache_path)return '<img src="'. $imagecache_path .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. $attributes .' />';
}
#9
I think this attacks the problem too late... this can be detected much earlier in imagecache_field_formatter($field, $item, $formatter)
254 if (!isset($item['filepath'])) {255 $file = _imagecache_file_load($item['fid']);
if (!count($file)) {
return '';
}
256 $item = array_merge($item, $file);
257 }
This works for me and saves unnecessary function calls.
#10
The dev-1.x version seems to have fixed the problem in the teaser but not in the full node view.
Edit: The dev-2.x version of imagefield together with the new imagecache seems to fix everything.
#11
OK, gonna test this new version.. thanks!
#12
OK..i tested the combination of the two dev. version...
imagefield-5.x-1.x-dev
and
imagecache-5.x-1.x-dev
Deleted the 2 previous modules,
then use update.php. After that, all images disappeared. Yay!
What I did is to update preset on both thumbnail and main image of imagecache module.
Seems fine to me now.
#13
This should be fixed in 2.x.