Parent term tagging breaks with TSS and multiple select

The problem with parent items is that the value of the parents wasn't being set correctly in the name of the form item, so even though a user can select the category they like, it doesn't get saved correctly.

if($term->is_parent){
        $term->weight = -11;
        $form['parent'] = _tss_branch($term->vid, $term, $term->parent_value, $term->parent_type);
      }

should be changed to

if($term->is_parent){
        $term->weight = -11;
        $form[$term->tid] = _tss_branch($term->vid, $term, $term->parent_value, $term->parent_type);
      }

patch attached.
-Jen

This seems to fix the problems I've been having where the top-level term would not get saved.

Also, the top-level term would not display in the views filter.

Thanks!

Thanks!

i found that it is better if you change it to :

    if($term->is_parent){
        $term->weight = -11;
        $form['parent'.$term->tid] = _tss_branch($term->vid, $term, $term->parent_value, $term->parent_type);
      }

Can you please try 5.x-1.10 and see if this problem still exists? I suspect it is now fixed. If it is, please mark this issue as fixed. Thanks.

Same bug fixed for version 1.5-1 by Ali in #4 reappeared in 1.10.

works for me

Still in 5.1-11.
Attached is the export XML file (thanks to the Taxonomy Import/Export module) of one of the conflicting vocabularies. It's called "Lieux", for "Location".

When I tag the parent Term "Aix-en-Provence", I have EACH time "Vaison-la-Romaine" tagged INSTEAD (same level in vocab).

In the Musique vocab, Prokoviev is always tagged instead of Bach. Just as a remark, none of the terms are the First or Last of the list.

works for me on 6.x

BUG confirmed: Parent term is not saved, other term gets saved instead.

Have applied the patch to the latest version for drupal 6 and works perfectly so far. Please maintainer commit this patch as this bug is critical: It practically renders the module unusable.

Cheers

This bug is still present for version 6.x-1.0. The attached patch fix the bux.

I also believe this is a critical bug (ok, this was just a +1 comment... :-) ).

Did you forget the patch? I can't find it... is it easily portable to d5 versions? Thanks in advance. Regards, Arsène

Still seems to be a bug in 6.x-1.0

Patch fixes the issue, i had to apply it myself (as i have other patches applied).

For me it was around line 194, in the _tss_branch() function.

Fixed in 6.x in #369656: TTS doesn't save parent terms?. Sorry, but you need to apply #4 for 5.x branch. I can't test, however.