I've got second time a case when file is broken - http://drupal.org/node/787652#comment-5837282
File contents get filled with zeros. Previous issue I cant remember...

When file was uploaded a testing bot successfully tested it http://qa.drupal.org/pifr/test/251454

and after a day I downloaded it from laptop
But after 4 days a content of the file is empty.

Bot's review log

[08:48:04] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/default/files/review/787652-forum-form_alter-split_43.patch 2>&1] succeeded.
[08:48:04] Command [git apply -v -p1 /var/lib/drupaltestbot/sites/default/files/review/787652-forum-form_alter-split_43.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout]
  Status [1]
 Output: [error: No changes].
[08:48:04] Applied [787652-forum-form_alter-split_43.patch] to:
 > no files

probably we need to make some changes in PIFR client to test a patch for it's content or better log message to make sure that patch has right content

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

I'm not sure it browser or storage issue...

Maybe better test patches with patch itself

# git apply --check -p1 787652-forum-form_alter-split_43.patch.1
git result is clean

# patch -p1 --dry-run < 787652-forum-form_alter-split_43.patch.1
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

patch os more verbose

skottler’s picture

skottler commented
Project: Drupal.org infrastructure » Drupal.org Testbots
Component: File server » Code
Status: Active » Needs review

Moving this to the testbot issue queue.

skottler’s picture

skottler commented

Moving this to the testbot issue queue.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Active

Please state clearly what happened here and how it might relate to the testbot.

Are you saying you can't successfully download a patch from Drupal.org? If so, that's not a testbot issue.

Please say exactly what happened. Was a particular patch changed after it was uploaded to Drupal.org?

andypost’s picture

andypost
he/him
Primary language Russian
commented

Randy we are not sure what's happened here.
When patch been uploaded to issue it was ok, I remember a testing was longer then usual also I recommend to use patch to apply patches because it could get more info - see #1

Also probably file was broken not the testbot but something else

nnewton’s picture

nnewton commented
Assigned: Unassigned » nnewton

Taking this, its looking a lot like this file was corrupted on the media server. Am still looking into it.

-N

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@andypost, although git patch and patch -p1 are similar for simple patches, they can't do moves or copies. The patch utility also leaves a lot of cruft laying around after any kind of patch application, and doesn't give good tools for testing without applying. Also note that git apply -v gives excellent diagnostics.

andypost’s picture

andypost
he/him
Primary language Russian
commented

@rfay, 

# git apply -v --check -p1 787652-forum-form_alter-split_43.patch.1

does not displays anything at all but patch does. You could try it by yourself with patch pointed in issue summary

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@andypost, 

git apply 787652-forum-form_alter-split_43.patch 
fatal: unrecognized input

Git seems to be doing its job. This is git 1.7.8.4 on MacOS.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Fixed

Calling this fixed. Feel free to reopen.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.