First a big thank you for this module! I customer has recently start "pesting" ;-) me for this feature. I read the "history" of og_user_roles and I'm impressed with your work to make all core hacks unnecessary. Now on to my issues.

Two of the extra features listed on the project homepage I believe should be moved to there own modules. "Notify group admin of new group subscribers" and "Create subgroups" really have nothing to do with user roles, they are nice features on there own.

I know it's easy to put all the features you need in to the same module but I think the module should win on being split up.

Now we come to one of my pet peeves, coding standards. Would you be interested in a "coding standard" patch for og_user_roles? Following the Drupal Coding Standards makes the code so much nicer and easier to work with.

http://drupal.org/coding-standards

Comments

somebodysysop’s picture

somebodysysop commented
Assigned: Unassigned » somebodysysop

First off, let me say that you are absolutely correct in everything you say.

However, the og_user_roles.module is made available to the general Drupal community at the discretion of my client, for whom it was written and is currently maintained. I've managed to show convince him that sharing this module is not only a good thing for the community, but for the module as well, and consequently, the site for which the module was developed. I doubt that he'll be interested in the time and effort involved in breaking up and maintaining mutltiple modules, even if that make logical sense.

I have to apologize for the non-standardized coding, but this module was began way back when I was not only new to Drupal, but new to PHP. I didn't even know there was a Drupal Coding Standard until I was actually ready to submit this as a module.

I've been trying to adhere to most of the standards as I continually update the module.

And, yes, I'd be interested in a "coding standard" patch, whatever that means, if it will be helpful.

Thanks for the suggestions.

somebodysysop’s picture

somebodysysop commented
Status: Active » Closed (works as designed)

If you want to supply that coding standards patch, that's cool. However, I don't think we'll be splitting up the og_user_roles module. We enjoy having the added functionality, and so far it really doesn't hurt anything to have it there.

somebodysysop’s picture

somebodysysop commented
Status: Closed (works as designed) » Closed (fixed)