The sudo module does not use 'user_save' when adjusting user roles, which bypasses other modules that implement hook_user. This is a particularly important for sites which need to maintain an audit trail of site changes. With this patch, the role_watchdog module can fill that need.

As an added bonus feature, this patch also reports to the user which role(s) they have been granted when they click the sudo button.

CommentFileSizeAuthor
#2 sudo-user-save-3.patch4.75 KBgreg.1.anderson
#1 sudo-use-user-save-2.patch4.87 KBgreg.1.anderson
sudo-use-user-save.patch4.86 KBgreg.1.anderson

Comments

greg.1.anderson’s picture

greg.1.anderson commented
StatusFileSize
new sudo-use-user-save-2.patch4.87 KB

The patch above had an error in the maintenance-mode handling code; fix attached.

greg.1.anderson’s picture

greg.1.anderson commented
StatusFileSize
new sudo-user-save-3.patch4.75 KB

Here is an updated patch that is the same as the patch above, save for the addition of one more bugfix. If a user is blocked or unblocked, then $edit->roles does not exist, causing sudo_user() to throw several warnings. This patch fixes these warnings by skipping the role-change checks when no role information was provided.

Interdiff:

@@ -70,8 +70,9 @@
   // make the change persistent; however, if the update is for the active user, then we ignore
   // the update. You cannot 'sudo' and then make yourself a permanent admin; also, hook_user is
   // called when the "sudo" button is used, we certainly do not want to remove those roles from
-  // the sudo table.
-  if (($op == 'update') && ($user->uid != $account->uid)) {
+  // the sudo table.  Also, note that if a user is blocked or unblocked, the 'roles' field
+  // of the $edit array might not exist.
+  if (($op == 'update') && ($user->uid != $account->uid) && isset($edit->roles)) {
 
     $default_sudo_roles = variable_get('sudo_default_roles', array());
     $save_roles = array_keys($edit['roles']);
dnotes’s picture

dnotes commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Closing 6.x issues.