In the iCal field settings, the option to override the site name under "Title" doesn't work. Instead of replacing the feed title X-WR-CALNAME with the entered text, it is appended to the site name and slogan.

The slogan textshouldprobably never be part of the feed title, even if the "use site name" checkbox is checked.

CommentFileSizeAuthor
#3 date_ical-fix_title_override-1529320-3.patch2.17 KBbabbage
#2 date_ical-fix_title_override-1529320-2.patch2.09 KBbabbage

Comments

babbage’s picture

babbage commented

Also have found this here.

babbage’s picture

babbage commented
Status: Active » Needs review
StatusFileSize
new date_ical-fix_title_override-1529320-2.patch2.09 KB

Attached patch fixes this issue. If the title override is entered in the "Feed: Style options" it is used, with a fallback first to the View title and secondly to the site name. The site caption that was previously inserted with the site title is excluded in all circumstances.

This patch formatted with git format-patch.

babbage’s picture

babbage commented
StatusFileSize
new date_ical-fix_title_override-1529320-3.patch2.17 KB

Ah darn it! Didn't quite commit all my changes. Ignore that previous patch... this one has an additional code comment to clarify what is happening here, and is the intended one. :)

This patch also formatted with git format-patch.

coredumperror’s picture

coredumperror commented
Status: Needs review » Closed (fixed)

This has been applied and committed to 7.x-1.x-dev. This will be available in the dev build within a few hours, and the official 7.x-1.2 release some time this week.

I've also applied this change to the 7.x-2.x branch. Since 7.x-1.x is in bug-fix only mode now, and will soon be abandoned, please upgrade to 7.x-2.x. If you have any problems with the 7.x-2.x branch, please open a new issue.