Provides additional info to context administration. It creates info page with all contexts and blocks to make it easier for administrator to navigate between context and block administration pages. It also shows overview of all blocks in a way that administrator can easily identify how blocks are used in particular contexts (useful on big websites with many blocks and contexts).

Link:
http://drupal.org/sandbox/m1n0/1362308

Works on Drupal 7.x.

Comments

m1n0’s picture

m1n0 commented
Status: Active » Needs review

*changing status to "needs review"

patrickd’s picture

patrickd commented

Welcome,

Please take a moment to make your project page follow tips for a great project page.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxm1n01362308git

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

bloke_zero’s picture

bloke_zero commented

This is a nice simple module that adds a much needed window into the context block settings - good job!

The code looks clean, well commented and secure. There are 2 nit picks I'd make:

Line 121:
'#empty' => t('no blocks in here'),

I'd rather see 'No blocks'

The other:

context_block_info.theme.inc

Line 13 should be:
$context_title = l($context->name, 'admin/structure/context/list/' . $context->name . '/edit', array('query' => drupal_get_destination()));
rather than
$context_title = l($context->name, '/admin/structure/context/list/' . $context->name . '/edit', array('query' => drupal_get_destination()));

(fwd slash in front of admin takes you out of the over lay etc.)

Hope to see this as an approved module soon!

bloke_zero’s picture

bloke_zero commented
Status: Needs review » Needs work
m1n0’s picture

m1n0 commented
Status: Needs work » Needs review

I updated the code according to comments and also I updated the project page.

Elvar’s picture

Elvar commented

Hi M1n0.

I tried to install your module, but context_ui is a dependency, so i tried to find this module with no luck, could you contribute with a link :-).

m1n0’s picture

m1n0 commented

context_ui is a part of the context project http://drupal.org/project/context

jleiva’s picture

jleiva commented

Hi, nice simple module, hope to see this as an approved module soon!

My manual review, some comments, no big thing:

  • Module works as described.
  • Searched module categories for similar projects: Content Display, Utility and Theme Enhancements; I have not found another module that has the same functionality
  • Maybe you should link to required module, no just add the module's name.
  • Project page, may be appropriate to include a picture of the settings panel.
  • You should update the README.txt, you are missing Requirements and Installation intructions

Good job @m1n0, nice module!

m1n0’s picture

m1n0 commented

Thanks for a nice review, I have done all suggested changes.

m1n0’s picture

m1n0 commented
Status: Needs review » Reviewed & tested by the community
patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Needs review

I'm sorry, please don't RTBC your own issues, see workflow

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Milena’s picture

Milena commented
Status: Needs review » Reviewed & tested by the community

Hi,

I'm still pretty new in reviewing modules. Some of minor cases I've found:

1) 'access callback' => 'user_access',
user_access is default access callback function. Of course putting such option is not a bug or mistake. But it is good to know.

2) In hook_form_alter() you have swich and only one case. It it better to use if instead.

3) foreach ($context_list_tagged as $context_name => $context) {
You do not use $context_name in your code.
foreach ($context_list_tagged as $context) { will be better.

Module seems good and useful. I believe issues I listed should not block module from RTBC, so I've changed status.

misc’s picture

misc commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, m1n0!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.