Hi,

While accessing the permissions, it gives the following error

Strict warning: Only variables should be passed by reference in filter_perms_admin_perm() (line 133 of /usr/local/share/drupal7/modules/filter_perms/filter_perms.module).
Strict warning: Only variables should be passed by reference in filter_perms_admin_perm() (line 134 of /usr/local/share/drupal7/modules/filter_perms/filter_perms.module).

Further while selecting and applying permissions, the same error repeats.
Hope it can be fixed soon.

Comments

cyu’s picture

Status: Active » Postponed (maintainer needs more info)

I don't have 5.4 at the moment to test, but can you check to see if warnings go away by replacing the filter_perms_admin_perm() function with:

function filter_perms_admin_perm() {
  $output = array();
  $output['filter_perms_admin_perm_filter'] = drupal_get_form('filter_perms_admin_perm_filter');
  $output['user_admin_permissions'] = drupal_get_form('user_admin_permissions');
  return $output;
}

I'll likely make that change anyhow, since this is a cleaner way of putting 2 forms on a page in D7 that I only found just now.

raveendrab’s picture

The modification seems to be working fine.

cyu’s picture

Status: Postponed (maintainer needs more info) » Fixed

Ok, I've made the change here: http://drupalcode.org/project/filter_perms.git/commit/3b7f126

I'll probably put out a release of some sort now and get off of dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.