When you run the Commit Features task, you are asked to put in a commit message. There is no way to tell without visiting the site's Features page what the changes are.

It would be great if the diff of what is going to be committed could be visible in that form.

CommentFileSizeAuthor
#4 devshop_hosting-add_diffs-1530542-4.patch2.18 KBergonlogic

Comments

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

Features Diff module is available now, we just have to have it enabled first. we should use some ajax magic to load it into the form!

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Project: DevShop Hosting (DEPRECATED) » DevShop
Version: 6.x-1.0-alpha1 »
Component: Code » devshop_hosting
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Needs work

I haven't been able to get this working. I figure the relevant code is in: http://drupal.org/sandbox/alchemist/1700552, but I could be wrong...

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new devshop_hosting-add_diffs-1530542-4.patch2.18 KB

The wrong node was being passed to _devshop_projects_site_has_module(). I moved the diff link up next to the environment, so that we can have one per environment, rather than have some fancy ajax to change the link elsewhere.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Version: » 6.x-1.x-dev
Priority: Normal » Major
Status: Needs review » Needs work

Let's update this patch to use the $node->environments list instead of 

$site_nids = array_flip($node->project_objects['site']);
jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Component: devshop_hosting » General
Issue summary: View changes
Status: Needs work » Closed (outdated)

Closing, thanks!

daggerhart’s picture

daggerhart commented
Issue tags: +Seattle2019