2 bugs fixed here :
- nodequeue_save does not save any nodes when $queu->size = 0
- the qid views arguments works with qid = $query, not $query->qid
not sure where that leaves the new 'title' argument (I did not test it)

CommentFileSizeAuthor
#4 nodequeue.module_0.patch874 bytesyched
nodequeue.module.patch1.08 KByched

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed. THanks!

yched’s picture

yched commented
Status: Fixed » Active

Earl, I don't think the fix you committed is right : unlimited queues have $queue->size = 0, so the code currently in 1.2 release still makes no nodes get added, am I wrong ?

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Fixed

Yea, I totally typo'd that. Sine this feature sees limited use, I'm not going to roll a new release just for this unless people ask for it.

yched’s picture

yched commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new nodequeue.module_0.patch874 bytes

OK, this issue is _doomed_.
This one is my fault - I left out the most important line in my initial patch...
nodequeue_save cannot store nodes for a good reason :-D

Sorry about that...

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Closed (won't fix)

The nodequeue 1.x line is no longer available.