In ldap_profile/LdapProfileConf.class.php, the call to ldap_authentication_get_valid_conf() function produces an error if ldap authentication is not enabled :"Fatal error: Call to undefined function ldap_authentication_get_valid_conf() in ../sites/all/modules/ldap/ldap_profile/LdapProfileConf.class.php on line 24 "

Perhaps the line dependencies[] = ldap_authentication should be added in the ldap_profile.info ?

CommentFileSizeAuthor
#2 1532084.patch2.04 KBjohnbarclay

Comments

johnbarclay’s picture

johnbarclay commented
Title: Error when ldap_profile enabled without ldap_authentication » LDAP Profile: Error when ldap_profile enabled without ldap_authentication
Priority: Normal » Major

The dependency should be removed. Nothing should rely on ldap authentication because many ldap scenarios use other single sign on methods such as shib, cas, etc. Thanks for catching this.

johnbarclay’s picture

johnbarclay commented
Assigned: Unassigned » johnbarclay
Status: Active » Fixed
StatusFileSize
new 1532084.patch2.04 KB

I removed the dependency. ldap_profile only needed the servers list, not any other data from ldap authentication. Attached is the patch and I committed it already.

lucuhb’s picture

lucuhb commented
Status: Fixed » Needs work

Thanks for your patch, but another error appears : " Call to undefined function ldap_authentication_get_valid_conf() in .../sites/all/modules/ldap/ldap_profile/LdapProfileConfAdmin.class.php on line 41"

johnbarclay’s picture

johnbarclay commented
Version: 7.x-1.0-beta9 » 7.x-1.x-dev

Got this and another dependency. Its committed also. thanks.

johnbarclay’s picture

johnbarclay commented
Status: Needs work » Needs review
johnbarclay’s picture

johnbarclay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.