could some suggest a reason why I'm getting this query 516 times when I edit a node?

[code]SELECT v.* FROM view_view v WHERE v.name = '--'[/code]

I'm trying to track down why some things are taking a long time to load on my site. I think that might have something to do with it.
I'm using Drupal 4.7 with the latest beta of views.

Comments

moggy’s picture

moggy commented

on further investigation, it's only appearing on nodes that have a CCK Node Reference field.

yched’s picture

yched commented
Project: Views (for Drupal 7) » Content Construction Kit (CCK)
Version: 4.7.x-1.6-beta5 » 5.x-1.x-dev
Component: Code » nodereference.module
Category: feature » bug

Thanks for the info. I'm moving to CCK then - I'll have to investigate.

Could you please confirm exactly which release of cck you are using ?
And if it's a dev release, please paste the // $id line at the beginning of nodereference.module

moggy’s picture

moggy commented

I've just downloaded and tried 4.7.x-1.5-1. I'm pretty sure that's what I had before anyway.

same results.

yched’s picture

yched commented
Version: 5.x-1.x-dev » 4.7.x-1.5-1

moving to correct version

yched’s picture

yched commented
Status: Active » Fixed

Fixed in all dev branches - many thanks to you for doing the right debug work, this has gone unnoticed for a while, a could have (maybe has indeed ?) been a pain to locate.

moggy’s picture

moggy commented

well, it seems to be fixed if I use a view to select which nodes can be referenced, but if I leave it at the default '--' I'm still getting it running the query once for each node eventually listed.

yched’s picture

yched commented

Well the whole point was to stop this query being made when selecting '--' (no view) :-), so you're telling me the fix did not change anythings ?

That's odd, I did actually test this to be OK (on the 5.0 bracnh, though, but this should really make no difference).
Are you positive you have downloaded the right code ? Maybe the 1.x-dev tarball had not been repackaged yet when you grabbed it ?
You should have this line at the beginning of nodereference.module :
// $Id: nodereference.module,v 1.25.2.38 2007/06/21 14:11:54 yched Exp $

moggy’s picture

moggy commented

that's beter. sorry for the false alarm. I can't have got the latest updates when I downloaded it yesterday.

I'm not getting the repeating sql now.

yched’s picture

yched commented

I like that better :-) Thanks for reporting.

karens’s picture

karens commented
Status: Fixed » Active

I just ran into this again on a field that was created long ago and never updated. The problem was that it was a nodereference field that pre-dated the views handling so it did not have any value for $field['advanced_view']. I had to go back and edit the field and save it so that the value got added.

So things will be OK if people are using updated fields. Maybe there's nothing to be done except be aware in case this is reported again. The other option is to add a check for whether the field has any value and skip the query in that case, too. It does seem to make some sense that you wouldn't run the query when there is no value.

Not sure which approach is best, open for ideas. If we don't want to do anything we can mark this fixed again.

yched’s picture

yched commented

agreed that we should check if the value is set (I thought we were already ?)

karens’s picture

karens commented

Nope, checking if != '--'. If there is no value at all, it is not '--', so it registers true and runs the query.

yched’s picture

yched commented
Status: Active » Fixed

OK - Fixed now.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
moshe weitzman’s picture

moshe weitzman commented

query was happenning 1850 times on Observer.com article form ... we might want to make a bug release for this.