Make forum module pass Coder Review

We have the go ahead with all these issues again, see #1518116: [meta] Make Core pass Coder Review for more details

This should wait for #1951268: Convert /forum and /forum/% to new router, remove forum_forum_load(), forum_get_topics(), create Forum service and #1974210: Convert admin/structure/forum to a Controller
forum.pages.inc and forum.admin.inc will be removed in those issues.
And forum.module will contain hooks only, no other code.

Working on it.

I take this one

Here is a patch.

Remaining errors are :
$phpcs --standard=Drupal core/modules/forum

FILE: ...s/forum/tests/src/Unit/Breadcrumb/ForumListingBreadcrumbBuilderTest.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------

FILE: /var/www/drupal8/core/modules/forum/src/ForumManager.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
125 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------

Correction

This looks great! a few minor changes required

1. +++ b/core/modules/forum/src/ForumManager.php
   @@ -22,10 +22,13 @@
   +  // A false positive error on that lines.
   

   » A false positive error on these lines.

2. +++ b/core/modules/forum/src/ForumSettingsForm.php
   @@ -28,7 +28,27 @@ public function getFormId() {
   -    $options = array(5, 10, 15, 20, 25, 30, 35, 40, 50, 60, 80, 100, 150, 200, 250, 300, 350, 400, 500);
   +    $options = array(
   +      5,
   +      10,
   +      15,
   +      20,
   +      25,
   +      30,
   +      35,
   +      40,
   +      50,
   +      60,
   +      80,
   +      100,
   +      150,
   +      200,
   +      250,
   +      300,
   +      350,
   +      400,
   +      500,
   +    );
   

   does this pass review if you split it to 5 per line, the readability here isn't great

3. +++ b/core/modules/forum/src/Tests/ForumIndexTest.php
   @@ -23,18 +23,27 @@ class ForumIndexTest extends WebTestBase {
   +        'edit any forum content','administer nodes',
   

   should be on own line?

4. +++ b/core/modules/forum/src/Tests/ForumTest.php
   @@ -316,7 +332,7 @@ private function doAdminTests($user) {
   +  private function editForumVocabulary() {
   
   @@ -400,10 +420,10 @@ function createForum($type, $parent = 0) {
   +  public function deleteForum($tid) {
   
   @@ -475,13 +495,13 @@ function testForumWithNewPost() {
   +  private function createForumTopic($forum, $container = FALSE) {
   

   please use protected instead

Thanks. Changes have been applied.

Thanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.

Closing in favor of #2571965: [meta] Fix PHP coding standards in core, stage 1. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.