Problem

  • If the Mollom service happens to be down and the Drupal module's client/key validation happens to be triggered during that time-frame, a bogus result is stored and sticks.
CommentFileSizeAuthor
#3 mollom.status-outage.3.patch2.42 KBsun
#2 mollom.status-outage.2.patch2.01 KBsun
mollom.status-outage.0.patch2 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, mollom.status-outage.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.status-outage.2.patch2.01 KB

Needs to check for === TRUE when comparing with old status, since positive integers (HTTP error codes) equal TRUE, too.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
StatusFileSize
new mollom.status-outage.3.patch2.42 KB

Committed #2.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Also pushed to 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 55c16d5 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1533456 by sun: Fixed False-negative client/key validation status if...

  • Commit 55c16d5 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1533456 by sun: Fixed False-negative client/key validation status if...