Notices and RTL issue with book.module

webernet - June 20, 2007 - 20:32
Project:Drupal
Version:6.x-dev
Component:book.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

After viewing a "Printer-friendly version" of a book page, the following notices appear on the next page load:
* notice: Undefined variable: output in \modules\book\book.module on line 805.
* notice: Undefined variable: output in \modules\book\book.module on line 748.
* notice: Undefined variable: output in \modules\book\book.module on line 805.
* notice: Undefined variable: output in \modules\book\book.module on line 748.
* notice: Undefined variable: content in \modules\book\book.module on line 688.
* notice: Use of undefined constant LANGUAGE_RTL - assumed 'LANGUAGE_RTL' in \modules\book\book.module on line 712.

The "Printer-friendly version" also loads both the regular and RTL stylesheets (consequently the page is right aligned), likely due to the last of the notices.

#1

keith.smith - June 20, 2007 - 20:37

A portion of this (Undefined constant LANGUAGE_RTL) came up in http://drupal.org/node/146425 ; I think a fix [for at least a bit of this] is included in that patch.

#2

webernet - June 20, 2007 - 20:40
Status:active» needs review

Attached patch fixes all the notices.

AttachmentSizeStatusTest resultOperations
patch_142.txt1.86 KBIgnoredNoneNone

#3

dmitrig01 - June 23, 2007 - 18:59
Status:needs review» reviewed & tested by the community

its ready

#4

Dries - June 28, 2007 - 08:56
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD.

#5

Anonymous - July 12, 2007 - 09:15
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.