Download & Extend
Issues

Notices and RTL issue with book.module

Posted by webernet on June 20, 2007 at 8:32pm
Project:Drupal core
Version:6.x-dev
Component:book.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

After viewing a "Printer-friendly version" of a book page, the following notices appear on the next page load:
* notice: Undefined variable: output in \modules\book\book.module on line 805.
* notice: Undefined variable: output in \modules\book\book.module on line 748.
* notice: Undefined variable: output in \modules\book\book.module on line 805.
* notice: Undefined variable: output in \modules\book\book.module on line 748.
* notice: Undefined variable: content in \modules\book\book.module on line 688.
* notice: Use of undefined constant LANGUAGE_RTL - assumed 'LANGUAGE_RTL' in \modules\book\book.module on line 712.

The "Printer-friendly version" also loads both the regular and RTL stylesheets (consequently the page is right aligned), likely due to the last of the notices.

Login or register to post comments

Comments

#1

Posted by keith.smith on June 20, 2007 at 8:37pm

A portion of this (Undefined constant LANGUAGE_RTL) came up in http://drupal.org/node/146425 ; I think a fix [for at least a bit of this] is included in that patch.

#2

Posted by webernet on June 20, 2007 at 8:40pm
Status:active» needs review

Attached patch fixes all the notices.

AttachmentSizeStatusTest resultOperations
patch_142.txt1.86 KBIgnored: Check issue status.NoneNone

#3

Posted by dmitrig01 on June 23, 2007 at 6:59pm
Status:needs review» reviewed & tested by the community

its ready

#4

Posted by Dries on June 28, 2007 at 8:56am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD.

#5

Posted by Anonymous on July 12, 2007 at 9:15am
Status:fixed» closed (fixed)
nobody click here