Hi, I understand captcha module disable page caching because it needs to show a different captcha to every anonymous user.
But what if I use the sub module RIDDLER and put only one question on all pages of my sites, there is only one answer to this question, everybody anonymous has to answer it to post. I'm not concerned about spammers finding the answer and be allowed to spam because I can easily change the question sitewide and the spammers won't bother finding the answer everytime I chhange it just for spamming my site. Plus the question is not in english.
But even with one question, the captcha module still disable page caching?
Shouldn't there be an option that if the admin wants always the same question/answer then there is no need to disable drupal cache?
Cheers,
James
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | interdiff-1534462-8-9.txt | 616 bytes | prudloff |
| #9 | riddler-1534462-9.patch | 888 bytes | prudloff |
Comments
Comment #1
soxofaan commentedI think support for re-enabling caching does not belong in the core CAPTCHA module and should be done in the riddler module.
Comment #2
awolfey commentedThe purpose of the module is to allow multiple questions. If you want one question you'll need a different solution.
Comment #3
alliax commentedno it's not to allow multiple questions, the purpose of this module is to provide a question and answer (riddler) submodule to captcha module. It doesn't matter if I use one or several questions and their answer. What is important is that the spambots can't guess the answer to the question. That's how you validate, accept or deny the content protected by captcha + riddler.
So the purpose of this module is not to allow multiple questions. It is one or more questions.
All I'm suggesting is that if it's one then the cache should not be disabled.
If you are not interested in this feature, that's fine, but don't take bad excuses like that, thank you. :-)
Comment #4
awolfey commentedYou're right, I'm being lazy about this. Also, one question is a valid use case. However, I'm too busy to take it on now. If you submit a patch I'll be happy to review it. Thanks.
Comment #5
alliax commentedThank you for your answer, I understand the problem of workload, it's just good to have the feature request active so someone can maybe see it and submit a patch in the future.
The problem with me is that I've never done a drupal module yet, not even a simple one, I haven't contributed to any code also, I don't think it will happen, but who knows..
In fact if I felt I could do it I think I'd have already done it or at least tried, and would have submitted patches, I like the idea of being a contributor in code not only in feature requests, but it hasn't happened yet :-)
So who knows, even if it's in one year, perhaps someone will post a patch one day, maybe someone has already done it on his own site and can easily submit a patch to this issue maybe next week or next month :-)
Comment #6
kaztur commented+1 for caching if only one question in Riddler.
Comment #7
MakeOnlineShop commentedAny update ?
Comment #8
gaëlg8 years later... :D
Comment #9
prudloff commented#8 is not enough. We also have to prevent riddler from calling the page_cache_kill_switch service.
Comment #10
anybodyNice work @prudloff. Technically RTBC!
Could this please be documented in the README? Might be important for large sites with heavy caching? Could you add that to your patch finally or create a MR?
Comment #11
anybodyComment #12
anybodyAs there's already a readme issue with an open MR, please simply add the lines for the README here: #3209344: Add README.md file
Afterwards we can RTBC and commit this.
Comment #13
adamps commentedI propose that the request from #12 be a follow-on action. It only makes sense once this patch has been committed and would be wrong if the README issue was committed first.
Comment #14
anybodyThanks @AdamPS! I'm ok with it, if someone does it ;)
Comment #16
anybodySorry for waiting so long! Committed! :)
@AdamPS: Would you be so kind to solve #12 then? ;)
Comment #17
adamps commentedGreat thanks for the commit.
Hmm actually I pointed out a potential problem and therefore proposed an order to do things. I didn't make a personal commitment to do the work myself😃. I don't have time to work on this myself at this exact moment I'm afraid. It seems like the best next step is to add a comment to #3209344: Add README.md file asking for a paragraph to be added. If you like I can, but I would really only be guessing as I don't know what you want to README to say. If you do it, then I feel you'd much more likely get what you were hoping for. The issue has in any case been waiting nearly a year for review after @Webbeh did what you asked for, so it would be nice to give some acknowledgement😃.
Comment #18
anybodyHaha @AdamPS :D, yes I'll have a look, but of course very much appreciate help. We're all busy people, needing clones or 48H on a 24H day ;)
Thanks a lot for your feedback :)