Geocoding from Address Field - Sensitivity to address2

One thing we could try is removing the comma that we place between address1 and address2 - although I'm worried that may screw up other geocoders like yahoo or yandex

Yes, yes it could...

Changing version.

If you are using addressfield, the string being fed to google is generated by the function geocoder_widget_parse_addressfield which is found in the file geocoder.widget.inc.

The function takes only one argument, $field_item, which contains only data held by address field. The function would have to be modified to take another argument so that the name of the geocoding service being used could also be passed in. Then you could include logic to skip the line that adds Address 2 (premise) to the string:

Line 405: if (!empty($field_item['premise'])) $address .= $field_item['premise'] . ',';

A quick hack for users of addressfield and geocoding with google would be to just comment that line out.

I ran into this problem with one of my projects. Since this appears to only be an issue with Addressfield/Google, I don't think it would make sense to mess with the geocoder.widget.inc code.

Each service has a handler (e.g. plugins/geocoder_handler/google.inc) which could be manipulated before it is passed to geocoder_widget_parse_addressfield().

I suggest, within geocoder_google_field(), unsetting $field_item['premise'] inside the addressfield if statement, with the assumption that no other service/field combination has the same issue.

hi, i got the same problem but your patch #6 not work!

thanks

@navalogan, can you tell me more?

Did the patch not apply to your 7.x-1.x-dev branch?

Were you able to successfully geocode an address without the premise (address 2) filled in?

Thanks for your quick reply. I applied the patch on my 7.x-1.x-dev branch but address 2 is not ignored. When I try without "address 2" it works fine.
Thanks

Sorry it's worked for me, I forgot to resave the existing content with the geocoder option "Force re-geocoding"
Thanks

Hi,

Is this patch still valid ?

Thanks!

I haven't had much time to dig into it, but I am still relying on this patch for a website.

I am using:
Geocoder - 7.x-1.3+18-dev with patch
Geofield - 7.x-2.3
Addressfield - 7.x-1.2

I have cloned the latest 7.x-1.x-dev and 7.x-2.x-dev on the same website without success.

It looks like 7.x-2.x-dev is still too D8 and is unusable in D7.

7.x-1.x-dev - The configuration page is gone and I am getting geoPHP and Google API errors when saving the node with the addressfield/geofield. So until the rest of this version works, it is hard to test to see if this patch is still needed.

The premise field is an issue for Openstreetmap Nominatim as well (hi everyone who has dealt with Googlemapsageddon). Honestly it seems to be a problem for all providers. IMO Address 2 should be a label only. Here is a small patch to remove premise from addressfield geocoding for any of the providers.

Re-roll of patch in comment #6 for Geocoder 7.x-1.7.