Issue for patch review on refactoring crm_core_activity.

CommentFileSizeAuthor
#1 crm_core_activity-refactor-1534870.patch33.4 KBygerasimov

Comments

ygerasimov’s picture

ygerasimov commented
Status: Active » Needs review
StatusFileSize
new crm_core_activity-refactor-1534870.patch33.4 KB
ygerasimov’s picture

ygerasimov commented
Status: Needs review » Fixed

Committed

dealancer’s picture

dealancer commented

nice one!

xcf33’s picture

xcf33 commented
Status: Fixed » Reviewed & tested by the community

Looks like the following was done

1. Moved the CRM Core Activity controller class to its separate file
2. Extend and specify separate class for activity types to alter later
3. .info file cleanup
4. .install using entity_create function instead of instantiate stdClass()
5. removing revision id from the schema
6. removing activity revision table
7. hook_entity_info property changes
8. removing all search related methods for activity search (moved search into activity ui class)
9. isLocked permission access method in the activity type class
10. adding comments
11. Proper access callback

Tested the ui and CRUD operations, just waiting to automated testing in the future.

dealancer’s picture

dealancer commented
Status: Reviewed & tested by the community » Fixed

As soon it was committed, the status of the issue should be fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f7837af on 7.x-1.x, development, import by ygerasimov: 
    Issue #1534870 by ygerasimov: Refactor activity module.

  • Commit f7837af on 7.x-1.x, development, import, activity_pages by ygerasimov: 
    Issue #1534870 by ygerasimov: Refactor activity module.