Now that 5.x-2.0-beta is out, the next critical step on the path to core is making this E_ALL compliant. It's going to have to be notice-free to make it into core, so we might as well do that directly in the 5.x-2.* series, too, since the resulting changes are always going to be for the better... Let's make it E_ALL compliant, first, then we can branch for DRUPAL-5--2, and finally port to D6 in HEAD.

CommentFileSizeAuthor
#1 update_status_E_ALL.patch.txt12.19 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new update_status_E_ALL.patch.txt12.19 KB

Hehe, and as I suspected, there were a bunch of bugs hidden in here. Granted, things are especially screwy now in D6 land for update_status, since there are only a tiny handful of modules with 6.x-compatible releases, not including core. ;) But, we should be able to handle all of these cases properly.

As far as I can tell, attached patch fixes all E_ALL notices from every aspect of the UI I could find. And, it seems to handle all the random edge cases nicely. That said, a more careful review and more testing would be really great.

killes@www.drop.org’s picture

killes@www.drop.org commented

Applied the patch clicked around, nothing seeem to be broken.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Committed to HEAD, revision 1.62 of update_status.module.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)