By boofums on

On my systems running PHP 4.1.2 I'm running into a problem where the top banner lines of the BlueMarine theme permanently disappear the moment I click on the administer link to configure them. I don't actually have to change a theme setting; I simply go to the theme configuration screen and it dies. It looks fine up until that point. Also, Chameleon will not allow itself to be enabled as well.

One of these systems is an upgrade from Drupal 4.4.1, the other was a fresh install of Drupal 4.5.1. I have yet another one with PHP 4.3 and it is completely happy so I'm guessing it has something to do with the version of PHP?

I tried looking at the bluemarine/xtemplate.xtmpl and the actual HTML sent to my browser. I'm new to themes and templates and don't really know what I'm doing yet, but the generated HTML doesn't look like it was even produced from the template -- that's not right is it?

For example, the !DOCTYPE statement in my bluemarine/xtemplate.xtmpl file says:

!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"

While the generated HTML has:
!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"

Comments

Steven’s picture

Steven commented

What exactly do you mean with "top banner lines"? If you're having problems with the themes page, it might be a PHP memory issue or a broken theme. The .xtmpl should match the general HTML skeleton of the page, so it sounds like something is causing Drupal to use the wrong theme on that page.

Your description is a bit ambiguous... does something happen when you /click/ the link (in that case it could be a browser issue) or when the target page loads?

boofums’s picture

boofums commented

The best way to understand what I mean is to go see it. Visit http://www.inetmonterey.net and log in as "guest" with a password of "guest". Presently, the site default theme is Pushbutton as it looks fine; the guest account is set to the BlueMarine theme so you can see how it is broken if you login that way.

By "missing banner lines" I mean the top of the page where the site logo, site name, primary and secondary menu links are gone. The left/right blocks and the main page content are all that remain.

Bluemarine starts out fine when I initially create the site. I can navigate all over and perform many tasks and Bluemarine looks just the way you expect it to. The point at which it breaks is when I navigate to administer >> themes >> configure. It's at the moment I simply enter the page -- not changing any theme settings -- that it breaks. Plus, I'm not saying the appearance of that page is broken, I'm saying the theme breaks for the entire site when I enter the page.

And there is an additional symptom where the Chameleon theme goes to the disabled state and if you try to enable it, it will silently put it back into the disabled state.

My broken bluemarine theme appears the same on IE6, Firefox 1.0, Firefox 0.92, and Mozilla x.something.

manatorg’s picture

manatorg commented

hm,
i have the same problem on woody. i'm using a backported debian package.
the problem is the description cell in table system.
search for "themes/bluemarine/xtemplate.xtmpl" in column filename. change the assosiated description cell.
i don't know why this happens (every time when you press save in the theme configuration) and if pushbutton is installed too.
maybe this is a problem with woodys old php.

boofums’s picture

boofums commented

I changed the description for bluemarine from "themes/bluemarine/xtemplate.xtmpl" to "bluemarine" in table "system" and that had no effect. Am I changing it to the right thing?

manatorg’s picture

manatorg commented

it is the dot between "xtemplate" and "xtmpl". at least in my installation.
old entry is something like:
"themes/bluemarine/xtemplate[here is a strange character]xtmpl"
new
"themes/bluemarine/xtemplate.xtmpl"

manatorg’s picture

manatorg commented

hi,
could you try this:
in modules/system.module replace the line (or comment out):

       $info->prefix = basename($$file->engine, '.engine');

with:

        $tmp_workaround=substr($file->engine, 0, strpos($file->engine,'.engine'));
        $info->prefix = $tmp_workaround;

this is in funktion
system_obtain_theme_info
around line 337.

after the basename call i get the bad string.

would be nice to know, if this solves your problem too.

cheers

manatorg’s picture

manatorg commented

sorry,
the above is not correct. though the theme is back, its configuration dialog is gone. this is because basename also removes the path.
my solution for now (until i find other bugs) is to substitute the basename function.
replace all existing basename-calls in module/system.module and includes/theme.inc with woody-basename and put this function in system.module

function woody_basename ($string,$ending=''){
        $pos = strpos($string,'/');
        while (!($pos === false))
        {
           $string=substr($string,$pos+1);
           $pos = strpos($string,'/');
        }
        if ($ending !="") {
          $string=substr($string,0, strpos($string,$ending));         }
        return $string;
}

edit:
ok, i think that is really the problem:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=217805

boofums’s picture

boofums commented

I put your woody_basename function into includes/woody_basename.inc, added include_once 'includes/woody_basename.inc';
statements to module/system.module and includes/theme.inc and replaced calls to basename() with woody_basename(), navigated to the administer >> themes >> configure page and it cleared up.
THANK YOU.

sharprez’s picture

sharprez commented

I'm so glad I just didn't post this problem... I've been having for 2 days! I searched.. and behold! The answer!

THANK YOU!

Follow the directions!!

change basename to woody_basename in both

modules/system.module AND includes/theme.inc

I pasted the code (in previous post) at the very bottom of the system.module (before the closing ?> ) and that was it!

Woo hoo!

:-D

Oh, BTW, this is NOT an Upgrade issue. I installed brand new Drupal 4.5.1 on Debian Linux 3.0r2(2.2). And its working nice! www.sharprez.com
Remember I've been using this software just a couple of days...it rocks!