I was always using the drupal-6.x dev version of this, since that pushkey command had the built in option of "--ssh-options" or something of the sort. As it was prior, without that, when I try the pushkey command and with the --ssh-options now, it doesn't establish the connection, due to the port being a non-standard one on my target machine.

See attached patch. Just makes use of the 'ssh-options' from the core-global-options and adds that to the command when establishing the connection. All of these changes are in pushkey.drush.inc - not sure if this should be mentioned in the help entry or not -- I'm no UX person, just someone trying to make this more useful.

CommentFileSizeAuthor
drush_extras-Implementing_ssh_options-000000-0.patch3.44 KBtnanek

Comments

tnanek’s picture

tnanek commented
Status: Active » Needs review
greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs review » Needs work

Thank you for contributing to drush_extras. I apologize for the poor state of the releases here; I will try to sort that out shortly. Until you posted this message, I did not realize what a sorry state it was in. Please pull the latest code via git from the 6.x-3.x branch; ssh-options is already supported there. I will clean this up as soon as I can. I also plan on changing pushkey to use ssh-copy-id, which is an openssl builtin that does more or less the same thing as pushkey. Pushkey will, after this change, become a simple wrapper that will pregenerate the pub/priv keys if necessary, and then call ssh-copy-id, perhaps taking the target parameters from a drush site alias. Not sure when I will get to this; patches welcome.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Needs work » Fixed

At its current status the command already uses ssh-copy-id and also takes care of --ssh-options. Related: #1849284: copy-id ignores ssh-options in alias record

it doesn't create keys though.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.