Facebook Comments Administration

welcome,

Nice to see you already cleaned up the code, good job :)

Please take a moment to make your project page follow tips for a great project page.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hi

You might add git clone --branch=7.x-1.x http://git.drupal.org/sandbox/johnzzon/1531972.git fb_comments_admin for faster cloning in main ticket.

You may check your code here: http://ventral.org/pareview/httpgitdrupalorgsandboxjohnzzon1531972git

Some minor fixes in Readme.txt needed

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 98 characters
25 | WARNING | Line exceeds 80 characters; contains 95 characters
--------------------------------------------------------------------------------

Feedback from manual code testing:
- I very like the idea. However, I don't understand how it works right away. How can I access the overview of comments? (this was not clear in the beginning)
- You could mention admin/content/fb-comments-admin in the Readme.txt
- No issues in Coder - awesome! :-)
- Unfortunately I could not fully check the funcitonality because I don't have facebook comments installed.
- Just wondering: What happens if a node has 200 comments within 1h. Does the facebook api return all 200 comments? Or a limited view? How do you deal with this?

admin.admin.inc
- Line 12, you should set relative path in module e.g. drupal_add_css(drupal_get_path('module', 'custom') . '/css/custom.css');

Hello,

I think, you can add the package in you .info file too.
May be more specific to Facebook.

Regards,

Nice module!, my personal review:

I'm testing the module in a large site. This site has a lot of fb comments, and after running cron no comments has been indexed. Maybe this is because you're using:

$url = node_uri($node);
$absolute_url = $base_url . '/' . $url['path'];
$req_url = "https://graph.facebook.com/comments/?ids=" . $absolute_url;

This not work for me because I'm using pathauto to generate urls. Try to use l() function to generate paths and fetch them from Facebook.

Also remove unused function fb_comments_admin_install().

Something like this to make your full URL with correct alias.

$absoluteurl = url($url['path'], array('absolute' => TRUE));

This should have been marked as needs work after comment #3.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Added "--branch=7.x-1.x" to the git clone info