Problem/Motivation

No feedback for users when updating Label, Format or widget settings on the Field Display Settings page. Users require this feedback because the drop down does not save the value. The save button needs to be clicked.

Proposed resolution

A prompt for Label, Format or widget settings changes that informs the user that the Save button also needs to be selected (Just like the blocks page).

Remaining tasks

None (Patch has been submitted and tested).

User interface changes

Warning message on Label, Format or widget settings changes.

API changes

None.

Original report by nick_schuch

This is the original report.

CommentFileSizeAuthor
#2 field-display-update-notice-1536252-1.patch1.28 KBnick_schuch
#1 field-display-update-notice-1536252-1.patch1.28 KBnick_schuch
ux_field_display_update_notice.png72.79 KBnick_schuch

Comments

nick_schuch’s picture

nick_schuch commented
StatusFileSize
new field-display-update-notice-1536252-1.patch1.28 KB
nick_schuch’s picture

nick_schuch commented
Status: Active » Needs review
StatusFileSize
new field-display-update-notice-1536252-1.patch1.28 KB
nick_schuch’s picture

nick_schuch commented
Issue summary: View changes

Update the summary.

nick_schuch’s picture

nick_schuch commented
Issue summary: View changes

Updated original report.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

This would have saved me some time on a number of occasions.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/field_ui/field_ui.admin.incundefined
@@ -1253,6 +1253,9 @@ function field_ui_display_overview_multistep_submit($form, &$form_state) {
+      // Notify the end user about the change

Missing trailing full stop.

+++ b/core/modules/field_ui/field_ui.admin.incundefined
@@ -1253,6 +1253,9 @@ function field_ui_display_overview_multistep_submit($form, &$form_state) {
+      drupal_set_message(t('* The changes to these fields will not be saved until the Save fields button is clicked.'),
+                     'warning');

No need to wrap to two lines.

+++ b/core/modules/field_ui/field_ui.admin.incundefined
@@ -1266,6 +1269,9 @@ function field_ui_display_overview_multistep_submit($form, &$form_state) {
+      // Notify the end user about the change

Missing trailing full stop.

+++ b/core/modules/field_ui/field_ui.admin.incundefined
@@ -1266,6 +1269,9 @@ function field_ui_display_overview_multistep_submit($form, &$form_state) {
+      drupal_set_message(t('* The changes to these fields will not be saved until the Save fields button is clicked.'),
+                     'warning');

No need to wrap to two lines.

Also, unsure about those asterisks.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Yeah, you're right Tim, the actual string is

Changes made in this table will not be saved until the form is submitted.

as can be seen here: http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/misc/...
The asterisk is added with Drupal.theme('tableDragChangedMarker') in the client side which adds this markup:

'<abbr class="warning tabledrag-changed" title="' . t('Changed') . '">*</abbr>'
cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Issue tags: +Needs backport to D7

Updating tags per http://drupal.org/node/1517250

nick_schuch’s picture

nick_schuch commented

Marked as duplicate. Refer to this ticket.

http://drupal.org/node/857312

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Status: Needs work » Closed (duplicate)

...proper status then ;)

nick_schuch’s picture

nick_schuch commented

Woops, cheers!

nick_schuch’s picture

nick_schuch commented
Issue summary: View changes

Updated summary.