Closed (fixed)
Project:
Drupal Most Popular
Version:
7.x-1.1
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Apr 2012 at 13:22 UTC
Updated:
5 Jun 2012 at 17:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
sathyanext commentedComment #2
albertczyk commentedSame issue. I'm looking at the module, and it seems it's using some outdated interface of SelectQuery object. So far, I've tried to update it this way, but this only changes the error to "Warning: Attempt to assign property of non-object en mostpopular_refresh() (línea 1062 de /var/www/vhosts/mysite/sites/all/modules/mostpopular/mostpopular.module)." BTW, mostpopular.module has only 145 lines...
Still working on it...
Comment #3
albertczyk commentedI think I've fixed it. Additionally, mostpopular_drupal_refresh_viewed() was returning an array of arrays, while it should be an array of objects. Here goes the patch.
Comment #4
albertczyk commentedA new version of the patch, I've just changed the variable name.
Comment #5
sathyanext commentedThank you very much for the patch:)
Let me try with this.
Comment #6
albertczyk commentedYou're welcome...
I'm rather new as a contributor to the issue management system of drupal.org, but I think that it won't hurt if I assign the bug to myself and change the status. Yes, for sure that it's written somewhere, but I don't have time right now to read the instructions.
Comment #7
markie commentedPatch failed at line 42. Also please review the naming conventions for the patches. I'll see if I can manually update this information.
Comment #8
albertczyk commentedOK, sorry! I've prepared a new patch and this one is well tested.
Comment #9
markie commentedThanks for taking care of that. Patch has been applied and pushed to the dev build. Please give it a try (may take 24 hours till build is complete)