Closed (fixed)
Project:
Update Status
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
22 Jun 2007 at 07:47 UTC
Updated:
6 Jul 2007 at 19:18 UTC
Jump to comment: Most recent file
I mentioned http://drupal.org/node/153757 in IRC, and when UnConeD saw http://drupal.org/files/issues/update_status_only_security_report.png he asked "What theme is that?". When I said it was from garland, he got annoyed at the hard-coded use of jet-black (#000). After a brief discussion, I tried taking those out of the update_status.css, such that we just use whatever foreground color the theme defines by default. Looks fine to me, even with the background colors, and I agree that the dark grey of garland is easier on the eyes, especially with so much stuff in bold.
Screenshot here. Patch next.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | update_status_use_theme_foreground_color.patch.txt | 640 bytes | dww |
| update_status_use_theme_foreground_color.png | 69.46 KB | dww |
Comments
Comment #1
dwwComment #2
Chris Johnson commentedTrivial change, looks fine to me.
Comment #3
dwwthanks, committed to HEAD.
Comment #4
merlinofchaos commentedYea? What happens when your theme has yellow, green or red as the primary foreground color? With our hardcoded background colors, that's going to look awful.
Comment #5
dwwYeah, I was thinking of that. However, I figured that if your theme is doing that, it can go out of its way to fix it, but the dark black wasn't looking ideal, hard-coding it to Garland's default foreground seems wrong, and Mr. Designer Guy(tm) was pushing for this.
We were discussing how to share classes and .css for this with watchdog, err, dblog, and the status report in core as this all moves into D6. Hopefully we'll come up with a clean solution that handles everything nicely.
That said, if you're strongly opposed, we could certainly undo it, or set it to Garland-grey, or something.
Comment #6
(not verified) commented