Without the permission to edit media, I get a javascript error

editButton.attr("href") is undefined
Line 70

Seems the javascript is trying todo some things with the editButton but that button does not display due to my permissions

see attached patch

CommentFileSizeAuthor
#4 media-no-editor-button-fix-reroll.patch2.02 KBraytiley
media-no-editor-button-fix.patch2.02 KBdgtlmoon

Comments

dgtlmoon’s picture

dgtlmoon commented

More accurately, when the user does not have the permission to edit files (which edit media depends on)

dddave’s picture

dddave commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This seems to be good. Could you possibly re-roll this with the Drupal coding standards around the if () calls in the JS?

raytiley’s picture

raytiley commented
StatusFileSize
new media-no-editor-button-fix-reroll.patch2.02 KB

Rerolled patch to include davereids request. Patch still applies cleanly. Did do any other testin.

raytiley’s picture

raytiley commented

Ooops... meant did not do any other tests above.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Thanks raytiley and dgtlmoon! Committed #4 to Git!
http://drupalcode.org/project/media.git/commit/a7284f4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.