Row highwater field is checked unprepared

It seems that Migrate is using the un-prepared value of timestamp when deciding to parse the row. In my case I implemented a prepareRow() method to transform CSV milliseconds timestamps to regular UNIX timestamp.

  public function prepareRow($row) {
    // Convert milliseconds timestamp to UNIX timestamp.
    if (isset($row->updated)) {
      $row->updated = floor($row->updated / 1000);
    }
  }

In includes/source.inc we have:

      // 5. So, we are using highwater marks. Take the row if its highwater field
      //    value is greater than the saved marked, otherwise skip it.
      elseif ($row->{$this->highwaterField['name']} > $this->activeMigration->getHighwater()) {
        // Fall through
      }

So...

• $row->{$this->highwaterField['name']} will be in milliseconds (unprepared)
• $this->activeMigration->getHighwater() will be in seconds, it was prepared before stored.

I think the above elseif statement must take the prepared $row->{$this->highwaterField['name']}

Here's a patch. I admit that is not so nice cloning the $row object but I didn't wanted to messup all the logic there by preparing the row in an early stage. This works for me.

Works as expected with #4. I had to apply it manually.. the branch is ahead.

Thank you!

Checked twice... Now existing, untouched records are updated every import :(

Tested and discovered that every time this condition is satisfied:

      // 2. If the row is not in the map (we have never tried to import it before),
      //    we always want to try it.
      elseif (!isset($row->migrate_map_sourceid1)) {
        // Fall through
      }

This mean that the existing rows doesn't have the migrate_map_sourceid1 property set at this moment. Not sure that this is coming from your patch.