Working on this...

CommentFileSizeAuthor
#4 1538456-fix-updatephp.patch3.76 KBkatbailey
#1 1538456-fix-updatephp.patch2.29 KBkatbailey

Comments

katbailey’s picture

katbailey commented
StatusFileSize
new 1538456-fix-updatephp.patch2.29 KB

There were fatal errors in update.php due to the fact that request() was not returning a request object (as none had been created). I copied the two lines from index.php to create a request object and pass it to request() and also replaced other uses of $_GET with $request->query->get().

katbailey’s picture

katbailey commented
Status: Active » Needs review
Crell’s picture

Crell commented

Looks good. I'm still seeing a number of fails in the update system, though, so leaving unmerged for now. We can merge when this is further fleshed out.

katbailey’s picture

katbailey commented
StatusFileSize
new 1538456-fix-updatephp.patch3.76 KB

OK, this now gets all of the upgrade path tests to pass - the attached patch corresponds to the last commit on the branch (I reverted the previous one).

(I confused myself a lot on this one, hopefully the patch does not reflect this)

Crell’s picture

Crell commented
Status: Needs review » Fixed

With #4, all of the update.php tests pass. Woo!

I cherry picked the commit over, then deleted the branch. Thanks, Kat!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.