And therefore cannot support editing the node object in the current implementation. This was a change from d6 to d7 in module_invoke_all. To fix this, we will need to either return the node object from the modules implementing this hook, or change the hook entirely, as well as those modules implementing it to make use of drupal_alter. Attached is a patch that does the former.

CommentFileSizeAuthor
#2 blogger_import-module_invoke_doesnt_support_pass_by_ref-2.patch1.51 KBrypit
blogger_import-module_invoke_doesnt_support_pass_by_ref-1.patch906 bytesrypit

Comments

rypit’s picture

rypit commented

Currently rolling a patch using drupal_alter, as this is the d7 convention. Will post after testing.

rypit’s picture

rypit commented
StatusFileSize
new blogger_import-module_invoke_doesnt_support_pass_by_ref-2.patch1.51 KB

Attached is an improved patch that makes used of drupal_alter. It also updates the readme and comments in code that address api usage. Note that because of the convention change, op has been moved to the last argument in the alter funciton. Thanks for the great module!

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work

Thanks for your time, but shouldn't this:

-      module_invoke_all('blogger_importer_node', 'presave', $node, $post);
+      drupal_alter('blogger_importer_node', $node, $post, $op);

be 

-      module_invoke_all('blogger_importer_node', 'presave', $node, $post);
+      drupal_alter('blogger_importer_node', $node, $post, 'presave');
ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Fixed

Commited with my change above

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

I am having a similar issue, is this the same? http://drupal.org/node/1795088